From: Nicolas Pitre <nico@cam.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org, Andy Parkins <andyparkins@gmail.com>
Subject: Re: [PATCH] Stop telling users we are 'defaulting to local storage area'.
Date: Thu, 14 Dec 2006 21:18:37 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612142059301.18171@xanadu.home> (raw)
In-Reply-To: <20061214230902.GA26506@spearce.org>
On Thu, 14 Dec 2006, Shawn O. Pearce wrote:
[...]
> It also breaks from our normal behavior of not printing
> anything if the command was successful.
Before everybody starts believing everybody agrees with this I'll have
to throw a tile in the pond.
I really don't think this is a good rule.
NOte that I'm not against commands that are silent by default. I really
think that git-add should remain silent on success by default when
successful.
But the rule of thumb should be about the importance of the action
performed by the command. git-add is a less important command than
git-init-db or git-commit _conceptually_. You can do multiple git-add
in whatever order, even repeatedly, and it won't change the outcome.
It is "conceptually lightweight". But git-init-db is really important.
Without it you just can't do anything. It should give the user the
impression that something did actually happen, especially since this is
the git comand any new git user is most likely to use first. Saying
back "git repository initialized" tells the user "OK you can start now".
Saying nothing might just leave the user wondering if everything is
actually fine.
next prev parent reply other threads:[~2006-12-15 2:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 23:09 [PATCH] Stop telling users we are 'defaulting to local storage area' Shawn O. Pearce
2006-12-15 2:18 ` Nicolas Pitre [this message]
2006-12-15 2:25 ` Shawn Pearce
2006-12-15 2:43 ` Nicolas Pitre
2006-12-15 5:44 ` [PATCH] Provide more meaningful output from 'git init-db' Shawn O. Pearce
2006-12-15 14:14 ` Jakub Narebski
2006-12-15 14:59 ` Shawn Pearce
2006-12-19 19:48 ` [PATCH] Stop telling users we are 'defaulting to local storagearea' David Lang
2006-12-15 14:10 ` [PATCH] Stop telling users we are 'defaulting to local storage area' Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612142059301.18171@xanadu.home \
--to=nico@cam.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).