From: Linus Torvalds <torvalds@osdl.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH/RFH] send-pack: fix pipeline.
Date: Fri, 29 Dec 2006 13:20:41 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0612291307520.4473@woody.osdl.org> (raw)
In-Reply-To: <7vzm96latb.fsf@assigned-by-dhcp.cox.net>
On Fri, 29 Dec 2006, Junio C Hamano wrote:
>
> I really need a sanity checking on this one. I think I got the
> botched pipeline fixed with the patch I am replying to, but I do
> not understand the waitpid() business. Care to enlighten me?
I think it was a beginning of a half-hearted attempt to check the exit
status of the rev-list in case something went wrong.
Which we simply don't do, so if git-rev-list ends up with some problem
(due to a corrupt git repo or something), it will just send a partial
pack.
For some reason I thought we had fixed that by just generating the object
list internally, but I guess we don't do that. That's just stupid. We
should make "send-pack.c" use
list-heads | git pack-objects --revs
list-heads | git-rev-list --stdin | git-pack-objects
because as it is now, I think send-pack is more fragile than it needs to
be.
Or maybe I'm just confused.
Linus
next prev parent reply other threads:[~2006-12-29 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 10:37 [PATCH/RFH] send-pack: fix pipeline Junio C Hamano
2006-12-29 20:13 ` Junio C Hamano
2006-12-29 21:20 ` Linus Torvalds [this message]
2006-12-29 23:53 ` Junio C Hamano
2007-01-02 14:06 ` Andy Whitcroft
2007-01-02 14:12 ` [PATCH] send pack check for failure to send revisions list Andy Whitcroft
2006-12-31 9:30 ` [PATCH/RFH] send-pack: fix pipeline Junio C Hamano
2006-12-31 19:56 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612291307520.4473@woody.osdl.org \
--to=torvalds@osdl.org \
--cc=apw@shadowen.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).