From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jim Meyering <jim@meyering.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-update-index.c (add_file_to_cache): Don't leak a cache entry.
Date: Fri, 16 Feb 2007 09:00:34 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702160858190.20368@woody.linux-foundation.org> (raw)
In-Reply-To: <87mz3e327y.fsf@rho.meyering.net>
On Fri, 16 Feb 2007, Jim Meyering wrote:
>
> - if (index_path(ce->sha1, path, &st, !info_only))
> + if (index_path(ce->sha1, path, &st, !info_only)) {
> + free(ce);
> return -1;
> + }
Well, the only user of this does:
if (add_file_to_cache(p))
die("Unable to process file %s", path);
so the leak is very shortlived ;)
Linus
next prev parent reply other threads:[~2007-02-16 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 9:01 [PATCH] builtin-update-index.c (add_file_to_cache): Don't leak a cache entry Jim Meyering
2007-02-16 17:00 ` Linus Torvalds [this message]
2007-02-18 9:10 ` Jim Meyering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702160858190.20368@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=jim@meyering.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).