From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: [PATCH] shortlog: prompt when reading from terminal by mistake
Date: Thu, 8 Mar 2007 09:31:55 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0703080928580.10832@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0703081755500.22628@wbgn013.biozentrum.uni-wuerzburg.de>
On Thu, 8 Mar 2007, Johannes Schindelin wrote:
>
> How about something totally different: "git log --shortlog". I.e.
Sure, but this is even worse, because the way you wrote the patch, now
git log --shortlog
will act as a filter too, which is even *more* confusing.
You also broke something even more fundamental. Try this:
git log -- --shortlog
with your patch ;)
But yeah, if "cmd_shortlog()" worked like "git log" (at least if it sees
the "--shortlog" flag) and with that obvious filename parsing thing fixed,
that thing would be fine.
Linus
next prev parent reply other threads:[~2007-03-08 17:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-08 10:12 [PATCH] shortlog: prompt when reading from terminal by mistake Junio C Hamano
2007-03-08 13:04 ` Johannes Schindelin
2007-03-08 15:07 ` GSoC project mentors Shawn O. Pearce
2007-03-08 16:04 ` Alex Riesen
2007-03-09 0:59 ` Shawn O. Pearce
2007-03-09 9:50 ` Alex Riesen
2007-03-09 15:58 ` Shawn O. Pearce
2007-03-08 17:27 ` Johannes Schindelin
2007-03-09 2:26 ` Shawn O. Pearce
2007-03-08 16:37 ` [PATCH] shortlog: prompt when reading from terminal by mistake Linus Torvalds
2007-03-08 17:10 ` Johannes Schindelin
2007-03-08 17:19 ` Matthieu Moy
2007-03-08 17:28 ` Johannes Schindelin
2007-03-08 17:31 ` Linus Torvalds [this message]
2007-03-08 17:37 ` Johannes Schindelin
2007-03-09 14:41 ` Jakub Narebski
2007-03-10 0:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703080928580.10832@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).