From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Alex Riesen <raa.lkml@gmail.com>, Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Allow git-diff exit with codes similar to diff(1)
Date: Tue, 13 Mar 2007 18:34:02 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703131831390.9690@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0703140216480.22628@wbgn013.biozentrum.uni-wuerzburg.de>
On Wed, 14 Mar 2007, Johannes Schindelin wrote:
>
> So, big master to hom everybody bows, how to return the correct value when
> executing a pager? Because this _has_ to be done if we go that way.
Why? If you execute the pager, nobody cares about the error value anyway.
I don't see why you would mix in a pager here. If you do
diff -u file1 file2 | less -S
the return value of the pipe will not only generally be totally
uninteresting and never used, but it will be the return value of "less"
anyway. Which is what we'd get quite naturally.
The return value of "git diff" really only is sensibly and meaningful when
you use it in a script *without* a pager (whether built-in or not).
Linus
next prev parent reply other threads:[~2007-03-14 1:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 0:17 [PATCH] Allow git-diff exit with codes similar to diff(1) Alex Riesen
2007-03-14 1:03 ` Johannes Schindelin
2007-03-14 1:20 ` Linus Torvalds
2007-03-14 1:23 ` Junio C Hamano
2007-03-14 1:13 ` Linus Torvalds
2007-03-14 1:18 ` Johannes Schindelin
2007-03-14 1:34 ` Linus Torvalds [this message]
2007-03-14 1:38 ` Johannes Schindelin
2007-03-14 8:37 ` Alex Riesen
2007-03-14 12:05 ` Johannes Schindelin
2007-03-14 12:26 ` Alex Riesen
2007-03-14 12:31 ` Johannes Schindelin
2007-03-15 12:49 ` Simon 'corecode' Schubert
2007-03-15 13:56 ` Alex Riesen
2007-03-14 1:31 ` Junio C Hamano
2007-03-14 8:19 ` Alex Riesen
2007-03-14 8:58 ` Junio C Hamano
2007-03-14 9:06 ` Junio C Hamano
2007-03-14 9:07 ` Alex Riesen
2007-03-14 9:36 ` Junio C Hamano
2007-03-14 9:46 ` Alex Riesen
2007-03-14 4:56 ` Junio C Hamano
2007-03-14 8:28 ` Alex Riesen
2007-03-14 9:04 ` Junio C Hamano
2007-03-14 14:01 ` Alex Riesen
2007-03-14 16:14 ` Junio C Hamano
2007-03-14 16:33 ` Alex Riesen
2007-03-14 16:37 ` Junio C Hamano
2007-03-14 17:12 ` Alex Riesen
2007-03-14 17:20 ` Junio C Hamano
2007-03-14 17:06 ` Junio C Hamano
2007-03-14 17:15 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703131831390.9690@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).