Re: [PATCH 3/2] Avoid unnecessary strlen() calls

[Linus Torvalds <torvalds@linux-foundation.org>]

On Sun, 18 Mar 2007, Shawn O. Pearce wrote:
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > 
> > Of course, the git gui blame colorization is clearly done by somebody who 
> > is still actively popping LSD with both fists and didn't realize that the 
> > 60's are long done, but that's another issue.
> 
> :-)
> 
> git-gui is open source.  I'd be happy to take a patch.  Or,
> since that is horribly messy Tcl/Tk code, just a better color
> suggestion. :-)

Yeah, the Tcl/Tk part means that I take one look and decide that I have 
absolutely zero clue..

Also, I'm not entirely sure what the "right" color is, but the changing 
colors do confuse me. Also, maybe I'm some kind of white suburban 
house-wife or something, but I prefer calmer pastel colors over the bright 
ones you've selected.

I would suggest:

 - some special color for "currently selected" (which defaults to being 
   the first one coming out of the blame thing, of course). 

   I'd suggest "black text on pale green background", but that may be just 
   me. Patricia calls the current color "hot pink", and maybe that's 
   appropriate for a certain segment of the population, but I'm not sure I 
   want to even *meet* that segment ;)

 - some *stable* graduated color for the rest. I don't think it 
   necessarily needs to be "older" vs "newer", and in fact I'd suggest 
   just two slightly different shades of gray for the background - just 
   pick alternating shades for each blame entry that comes in (and leave 
   un-blamed lines white).

The flickering just makes me go "ooh, I'm really happy I don't have 
epilepsy, because otherwise I'd be writhing on the floor every time I 
tried to use this tool".

			Linus