git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] prefer "git COMMAND" over "git-COMMAND" in gitk
@ 2007-03-19 23:00 Brandon Casey
  2007-03-21 11:04 ` Paul Mackerras
  0 siblings, 1 reply; 2+ messages in thread
From: Brandon Casey @ 2007-03-19 23:00 UTC (permalink / raw)
  To: git


Preferring git _space_ COMMAND over git _dash_ COMMAND allows the
user to have only git and gitk in their path. e.g. when git and gitk
are symbolic links in a personal bin directory to the real git and gitk.

Perfect time to say Thanks for the great work.

-brandon


--- gitk.orig   2007-02-13 20:46:46.000000000 -0600
+++ gitk        2007-03-19 17:46:55.142030000 -0500
@@ -1904,7 +1904,7 @@
      } else {
         set gdtargs [list "-S$highlight_files"]
      }
-    set cmd [concat | git-diff-tree -r -s --stdin $gdtargs]
+    set cmd [concat | git diff-tree -r -s --stdin $gdtargs]
      set filehighlight [open $cmd r+]
      fconfigure $filehighlight -blocking 0
      fileevent $filehighlight readable readfhighlight
@@ -1956,7 +1956,7 @@
      }
      if {[eof $filehighlight]} {
         # strange...
-       puts "oops, git-diff-tree died"
+       puts "oops, git diff-tree died"
         catch {close $filehighlight}
         unset filehighlight
      }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] prefer "git COMMAND" over "git-COMMAND" in gitk
  2007-03-19 23:00 [patch] prefer "git COMMAND" over "git-COMMAND" in gitk Brandon Casey
@ 2007-03-21 11:04 ` Paul Mackerras
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mackerras @ 2007-03-21 11:04 UTC (permalink / raw)
  To: Brandon Casey; +Cc: git

Brandon Casey writes:

> Preferring git _space_ COMMAND over git _dash_ COMMAND allows the
> user to have only git and gitk in their path. e.g. when git and gitk
> are symbolic links in a personal bin directory to the real git and gitk.

Thanks for the patch.  It was whitespace-damaged but I fixed it up
(this once) and applied it.  Also, if you send any larger patches in
future I'd like a Signed-off-by line with them (this one was trivial
enough that I applied it without).

Paul.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-03-21 11:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-19 23:00 [patch] prefer "git COMMAND" over "git-COMMAND" in gitk Brandon Casey
2007-03-21 11:04 ` Paul Mackerras

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).