From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>,
Pavel Roskin <proski@gnu.org>,
Alexander Litvinov <litvinov2004@gmail.com>
Subject: Re: git 1.5.1-rc1 doesn't like empty files
Date: Tue, 20 Mar 2007 08:45:21 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703200843270.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <200703200926.05176.andyparkins@gmail.com>
On Tue, 20 Mar 2007, Andy Parkins wrote:
> On Tuesday 2007 March 20 08:49, Junio C Hamano wrote:
>
> > >> noticed, because almost nobody uses it.
> > >
> > > I'm not sure that's going to be true for long - the 1.5.0 release notes
> > > recommended setting it (assuming you didn't need backward compatibility)
> > > - which is exactly what I (and I'm sure others) did.
> >
> > Well, it is fixed in 'master' to be in -rc2, and that validation
> > does not exist in 'maint', so no harm is done.
>
> It wasn't the presence of the bug I was highlighting - it was the idea that
> nobody uses that option.
Yeah, I'm actually happy that people seem to be using it, and it looks
like the bug really was totally harmless apart from triggering a bogus
error (ie it would never have corrupted anything, it just triggered an
error that it shouldn't have).
And I think the only thing that could ever trigger it was really that
special case of a zero-sized blob (or maybe an empty tree, but git doesn't
generate those natively unless you do magic stuff by hand).
Linus
next prev parent reply other threads:[~2007-03-20 15:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 3:30 git 1.5.1-rc1 doesn't like empty files Pavel Roskin
2007-03-20 4:24 ` Nicolas Vilz
2007-03-20 4:54 ` Linus Torvalds
2007-03-20 5:08 ` Pavel Roskin
2007-03-20 5:41 ` Linus Torvalds
2007-03-20 5:50 ` Pavel Roskin
2007-03-20 5:56 ` Shawn O. Pearce
2007-03-20 7:04 ` Alexander Litvinov
2007-03-20 8:43 ` Andy Parkins
2007-03-20 8:49 ` Junio C Hamano
2007-03-20 9:26 ` Andy Parkins
2007-03-20 15:45 ` Linus Torvalds [this message]
2007-03-20 5:29 ` Junio C Hamano
2007-03-20 5:47 ` Pavel Roskin
2007-03-20 5:49 ` Linus Torvalds
2007-03-20 6:00 ` Junio C Hamano
2007-03-20 6:05 ` Junio C Hamano
2007-03-20 15:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703200843270.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=litvinov2004@gmail.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).