git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Be more careful about zlib return values
Date: Wed, 21 Mar 2007 08:29:30 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0703210827591.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <7vodmn2eya.fsf@assigned-by-dhcp.cox.net>



On Wed, 21 Mar 2007, Junio C Hamano wrote:
> 
> I am observing a very curious performance regression with this
> patch.  I do not see anything obviously wrong correctness-wise
> nor performance-wise with it.

Ok, the test you are doing won't call the write function at all, so the 
performance effect you see is almost certainly due to [un]lucky I$ 
placement. It happens..

		Linus

      reply	other threads:[~2007-03-21 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-20 18:38 Be more careful about zlib return values Linus Torvalds
2007-03-21  8:11 ` Junio C Hamano
2007-03-21 15:29   ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0703210827591.6730@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).