From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-revert: Revert revert message to old behaviour
Date: Fri, 23 Mar 2007 09:27:53 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703230926380.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0703231705150.4045@wbgn013.biozentrum.uni-wuerzburg.de>
On Fri, 23 Mar 2007, Johannes Schindelin wrote:
>
> When converting from the shell script, based on a misreading of the
> sed invocation, the builtin included the abbreviated commit name,
> and did _not_ include the quotes around the oneline message.
>
> This fixes it.
How about the empty line in between the message and the "This reverts
commit "..
> + add_to_msg("Revert \"");
> add_to_msg(oneline);
> - add_to_msg("\nThis reverts commit ");
> + add_to_msg("\"\nThis reverts commit ");
This should probably be
add_to_msg("\"\n\nThis reverts commit ");
with *two* \n's, no?
Linus
next prev parent reply other threads:[~2007-03-23 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 15:07 "git revert" message changes Linus Torvalds
2007-03-23 16:06 ` [PATCH] git-revert: Revert revert message to old behaviour Johannes Schindelin
2007-03-23 16:27 ` Linus Torvalds [this message]
2007-03-23 19:13 ` Johannes Schindelin
2007-03-24 9:54 ` Junio C Hamano
2007-03-24 12:34 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703230926380.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).