From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: [PATCH] Convert emailing part of hooks--update to hooks--post-receive
Date: Sat, 24 Mar 2007 09:12:28 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703240858370.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <200703241550.05590.andyparkins@gmail.com>
On Sat, 24 Mar 2007, Andy Parkins wrote:
>
> Oh dear; I had no idea that packed refs made the ref file itself
> disappear.
Everybody should do
git pack-refs --all --prune
occasionally to see this. In fact, I think we should probably make that
part of "git gc" (which currently doesn't pack branches at all, just tags,
since it omits the "--all").
> Would
>
> git-rev-parse $refname
>
> Be a better way of getting the revision?
That's always the correct way to get a revision, although you should use
git-rev-parse --verify "$refname"^0
to make sure that you get a commit (of course, if you don't want a
commit, but any random ref-SHA1, remove the "^0" from the end!).
HOWEVER. "git-rev-parse" will take any arbitrary SHA1-expression, which
may or may not be what you want. If you actually also want to verify that
it's strictly a branch name (or other ref-name), rather than just a random
SHA1 expression, you should do
git show-ref [--verify] refname
where the "--verify" again enables strict checking. HOWEVER, it will not
check that it's a commit, so if you need the resulting SHA1 to be of a
specific type, you need to do that separately.
Side note: those two "--verify" calls do two different kinds of strict
checking, because "show-ref" and "rev-parse" are different things. In
"git-rev-parse" it checks that the argument is exactly *one* SHA1 value,
and not some flag or a SHA1 range. Because "git rev-parse" can take a lot
of different input formats. In contrast, in "git show-ref", the stricter
checking enabled by "--verify" will just force it to not do any "pattern"
for the ref, but it wants an *exact* refname.
Linus
next prev parent reply other threads:[~2007-03-24 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 10:23 [PATCH] Convert emailing part of hooks--update to hooks--post-receive Andy Parkins
2007-03-24 12:43 ` Junio C Hamano
2007-03-24 15:44 ` Andy Parkins
2007-03-24 16:12 ` Linus Torvalds [this message]
2007-03-25 7:13 ` Junio C Hamano
2007-03-25 7:07 ` Junio C Hamano
2007-03-25 7:50 ` Junio C Hamano
2007-03-25 8:51 ` Andy Parkins
2007-03-25 9:13 ` Junio C Hamano
2007-03-30 19:16 ` [PATCH v2] Reimplement emailing part of hooks--update in contrib/hooks/post-receive-email Andy Parkins
2007-03-31 11:36 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703240858370.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).