From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Rogan Dawes <lists@dawes.za.net>,
Andy Parkins <andyparkins@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Show binary file size change in diff --stat
Date: Wed, 4 Apr 2007 09:40:13 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704040935350.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0704041819340.4045@wbgn013.biozentrum.uni-wuerzburg.de>
On Wed, 4 Apr 2007, Johannes Schindelin wrote:
>
> The subtle difference: your approach is _expensive_ in terms of CPU time,
> while the byte change approach is _dirt cheap_.
Well, you could do a combination (still dirt cheap):
- show the size before/after (and yes, new/delete should be separate from
"zero size before/after")
- show the size of the binary patch.
No "X added bytes" vs "Y bytes deleted", just "size of binary patch". It
could be really small, even if 10k was deleted, or the file was totally
re-organized by moving chunks around.
It would still be a meaningful thing to know - if only because it tells
you how much space the delta takes. So even if it's a .jpg, and the actual
*picture* didn't change a lot (ie you did some new version with color
correction or something: it looks similar to the old one, but the *diff*
is basically "rewrite it all"), knowing the size of the delta at least has
the meaning of "this is how basically much space it will take when you
send the binary diff in an email".
That's fairly close to what "5 new lines, 1 deleted line" message means.
It's another way to give you an approximate idea of how big the changes
were.
Linus
next prev parent reply other threads:[~2007-04-04 16:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 13:14 [PATCH] Show binary file size change in diff --stat Andy Parkins
2007-04-04 13:34 ` Rogan Dawes
2007-04-04 14:40 ` Geert Bosch
2007-04-04 16:00 ` Rogan Dawes
2007-04-04 14:40 ` Andy Parkins
2007-04-04 15:51 ` Rogan Dawes
2007-04-04 16:22 ` Johannes Schindelin
2007-04-04 16:26 ` Rogan Dawes
2007-04-04 16:40 ` Linus Torvalds [this message]
2007-04-04 16:59 ` Johannes Schindelin
2007-04-04 17:12 ` Linus Torvalds
2007-04-04 17:47 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2007-02-28 13:03 Andy Parkins
2007-02-28 14:44 ` Johannes Schindelin
2007-02-28 14:51 ` Nicolas Pitre
2007-02-28 15:15 ` Andy Parkins
2007-02-28 15:37 ` Johannes Schindelin
2007-02-28 18:42 ` Andy Parkins
2007-02-28 19:41 ` Johannes Schindelin
2007-02-28 15:26 ` Andy Parkins
2007-02-28 18:58 ` Rogan Dawes
2007-02-28 19:42 ` Johannes Schindelin
2007-02-28 21:27 ` Rogan Dawes
2007-03-01 1:09 ` Johannes Schindelin
2007-03-01 6:58 ` Rogan Dawes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704040935350.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=lists@dawes.za.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).