From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Dana How <danahow@gmail.com>, Nicolas Pitre <nico@cam.org>,
Junio C Hamano <junkio@cox.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size
Date: Thu, 5 Apr 2007 08:34:56 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704050831520.6730@woody.linux-foundation.org> (raw)
In-Reply-To: <20070405065433.GD5436@spearce.org>
On Thu, 5 Apr 2007, Shawn O. Pearce wrote:
>
> For glibc we do try to set _FILE_OFFSET_BITS to 64
I repeat: that's _broken_.
It's in no way portable. It's a glibc horror. It should not be used.
It was a quick hack, but the real way to do it is to use "loff_t" and
"llseek".
But there simply isn't any way to do mmap() or pread() portably outside
the 32-bit area. So there are good reasons why we should just limit
pack-files to 32-bits on 32-bit architectures.
So I think that Dana's approach is just fundamentally correct. Yeah, we
should probably have a 64-bit index as a *possibility*, but it simply
isn't a replacement for "keep packs under 2GB in size".
Linus
next prev parent reply other threads:[~2007-04-05 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 20:40 [PATCH] git-{repack,pack-objects} accept --{pack,blob}-limit to control pack size Dana How
2007-04-04 22:04 ` Nicolas Pitre
2007-04-04 22:55 ` Dana How
2007-04-05 3:17 ` Nicolas Pitre
2007-04-05 7:15 ` Shawn O. Pearce
2007-04-05 15:52 ` Nicolas Pitre
2007-04-05 6:54 ` Shawn O. Pearce
2007-04-05 15:34 ` Linus Torvalds [this message]
2007-04-05 15:53 ` Shawn O. Pearce
2007-04-05 16:21 ` Linus Torvalds
2007-04-05 17:14 ` Shawn O. Pearce
2007-04-05 21:17 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704050831520.6730@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=danahow@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).