git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5] t1000: fix case table.
@ 2007-04-07 14:39 Junio C Hamano
  2007-04-07 18:01 ` Daniel Barkalow
  0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2007-04-07 14:39 UTC (permalink / raw)
  To: git; +Cc: Daniel Barkalow, Alex Riesen, Johannes Schindelin

Case #10 is not handled with unpack-trees.c:threeway_merge()
internally, unless under the agressive rule, and it is not a
bug.  As the test expects, ND (one side did not do anything,
other side deleted) case was meant to be handled by the caller's
policy (e.g. git-merge-one-file or git-merge-recursive).

Signed-off-by: Junio C Hamano <junkio@cox.net>
---
 t/t1000-read-tree-m-3way.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/t/t1000-read-tree-m-3way.sh b/t/t1000-read-tree-m-3way.sh
index e26a36c..de4e5eb 100755
--- a/t/t1000-read-tree-m-3way.sh
+++ b/t/t1000-read-tree-m-3way.sh
@@ -184,7 +184,7 @@ checked.
   9  exists  O!=A    missing   no merge    must match A and be
                                            up-to-date, if exists.
  ------------------------------------------------------------------
- 10  exists  O==A    missing   remove      ditto
+ 10  exists  O==A    missing   no merge    must match A
  ------------------------------------------------------------------
  11  exists  O!=A    O!=B      no merge    must match A and be
                      A!=B                  up-to-date, if exists.
-- 
1.5.1.81.gee969

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/5] t1000: fix case table.
  2007-04-07 14:39 [PATCH 1/5] t1000: fix case table Junio C Hamano
@ 2007-04-07 18:01 ` Daniel Barkalow
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Barkalow @ 2007-04-07 18:01 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git, Alex Riesen, Johannes Schindelin

On Sat, 7 Apr 2007, Junio C Hamano wrote:

> Case #10 is not handled with unpack-trees.c:threeway_merge()
> internally, unless under the agressive rule, and it is not a
> bug.  As the test expects, ND (one side did not do anything,
> other side deleted) case was meant to be handled by the caller's
> policy (e.g. git-merge-one-file or git-merge-recursive).

Looks like I neglected to update (or remove) that table; 
Documentation/technical/trivial-merge.txt agrees with your change.

	-Daniel
*This .sig left intentionally blank*

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-04-07 18:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-07 14:39 [PATCH 1/5] t1000: fix case table Junio C Hamano
2007-04-07 18:01 ` Daniel Barkalow

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).