From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] Refactor patch-id filtering out of git-cherry and git-format-patch.
Date: Sat, 14 Apr 2007 10:57:32 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0704141028220.18846@racer.site> (raw)
In-Reply-To: <7vmz1fua4r.fsf_-_@assigned-by-dhcp.cox.net>
Hi,
On Tue, 10 Apr 2007, Junio C Hamano wrote:
> This implements the patch-id computation and recording library,
> patch-ids.c, and rewrites the get_patch_ids() function used in
> cherry and format-patch to use it, so that they do not pollute
> the object namespace. Earlier code threw non-objects into the
> in-core object database, and hoped for not getting bitten by
> SHA-1 collisions. While it may be practically Ok, it still was
> an ugly hack.
No, it was not an ugly hack. Instead, it served as a reminder that we
_rely_ on different content having different SHA-1 ids.
Having said that, I do not particularly mind patch-ids being stored
elsewhere, if only as a clean up. However, I would have liked your patch
so much more if you had done the only sane thing: resurrect object-hash.c.
Now, we have yet another data structure which is unnecessarily bound to a
certain use, and the next person wanting a new hashmap needs to add _yet_
another data structure.
Ciao,
Dscho
next prev parent reply other threads:[~2007-04-14 8:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-04 11:36 How can I easily verify my diffs are in parent branch? Alex Bennee
2007-04-04 12:28 ` Alex Riesen
2007-04-04 12:56 ` Andy Parkins
2007-04-04 15:12 ` Linus Torvalds
2007-04-05 5:25 ` Junio C Hamano
2007-04-05 9:16 ` David Kågedal
2007-04-05 10:24 ` Junio C Hamano
2007-04-05 14:53 ` [PATCH] Document --left-right option to rev-list Brian Gernhardt
2007-04-05 21:37 ` Junio C Hamano
2007-04-07 10:54 ` Alex Riesen
2007-04-09 11:07 ` [PATCH 1/2] git-log --cherry-pick Junio C Hamano
2007-04-10 22:39 ` [PATCH 1/4] Add %m to '--pretty=format:' Junio C Hamano
2007-04-10 22:39 ` [PATCH 2/4] Refactor patch-id filtering out of git-cherry and git-format-patch Junio C Hamano
2007-04-14 8:57 ` Johannes Schindelin [this message]
2007-04-10 22:40 ` [PATCH 3/4] git-log --cherry-pick A...B Junio C Hamano
2007-04-10 22:41 ` [PATCH 4/4] Documentation: --cherry-pick Junio C Hamano
2007-04-09 11:11 ` [PATCH 2/2] Add %m to '--pretty=format:' Junio C Hamano
2007-04-11 11:37 ` How can I easily verify my diffs are in parent branch? Alex Bennee
2007-04-11 16:00 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704141028220.18846@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).