From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andy Parkins <andyparkins@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <junkio@cox.net>
Subject: Re: Expose subprojects as special files to "git diff" machinery
Date: Sun, 15 Apr 2007 14:03:26 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704151402130.5473@woody.linux-foundation.org> (raw)
In-Reply-To: <200704152116.26773.andyparkins@gmail.com>
On Sun, 15 Apr 2007, Andy Parkins wrote:
> > +++ b/sub-A
> > @@ -1 +1 @@
> > -Subproject commit 2de597b5ad348b7db04bd10cdd38cd81cbc93ab5
> > +Subproject commit e8f11a45c5c6b9e2fec6d136d3fb5aff75393d42
>
> Isn't this dangerous because it looks just like a normal diff with a
> file being rewritten, when in truth it is a tree entry record being
> rewritten.
Well, that's exactly what symlinks do too.
You have to look at the mode to know what the rewriting *means*.
But yeah, I wouldn't object at all to making it an "extended git header"
instead (possibly just for subprojects, possibly for symlinks too)
Linus
next prev parent reply other threads:[~2007-04-15 21:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 18:14 Expose subprojects as special files to "git diff" machinery Linus Torvalds
2007-04-15 19:01 ` Sam Ravnborg
2007-04-15 19:05 ` Linus Torvalds
2007-04-15 19:20 ` Sam Ravnborg
2007-04-15 20:16 ` Andy Parkins
2007-04-15 21:03 ` Linus Torvalds [this message]
2007-04-18 8:46 ` git-format-patch for binary files / merges [Re: Expose subprojects as special files to "git diff" machinery] Sam Vilain
2007-04-18 11:49 ` Alex Riesen
2007-04-18 11:52 ` Johannes Schindelin
2007-04-18 15:47 ` Linus Torvalds
2007-04-18 16:08 ` Junio C Hamano
2007-04-19 8:28 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704151402130.5473@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=andyparkins@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).