git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Christian <crich-ml@beronet.com>
Cc: git@vger.kernel.org
Subject: Re: git push over http is very dangerous
Date: Mon, 16 Apr 2007 12:38:24 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0704161212140.5473@woody.linux-foundation.org> (raw)
In-Reply-To: <462394AC.303@beronet.com>



On Mon, 16 Apr 2007, Christian wrote:
>
> We have moved from CVS to git in the beginning of last week, all went well
> until this weekend. This weekend one developer wanted to push some of his
> local modifications, unfortunately during the push his http connection seemed
> to have broken or so. Unfortunately git does not prove if the push went well.
> Therefore our repository was broken this morning.

I have to agree: pushing over http really is dangerous. It's not 
*supposed* to be (it tries to update the refs only after it has uploaded 
all objects), but it fundamentally cannot do all the validity tests that 
the "real" git transfer processes do on the receiving side.

And I think git-http-push is pretty fundamentally broken anyway. It 
doesn't really seem to check for errors. So it doesn't do some of the 
checks it *could* do.

I would strongly suggest against http pushing (I'd suggest against pulling 
too, but at least you can't screw up too badly by just reading ;)

I'd also love it if somebody were to actually look into making 
http-pushing a bit safer. It really needs somebody who cares about it, or 
it should likely just be disabled entirely (perhaps with a config option 
that you have to enable to get it - so that people *realize* that it's not 
maintained and not really supported).

		Linus

  reply	other threads:[~2007-04-16 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16 15:22 git push over http is very dangerous Christian
2007-04-16 19:38 ` Linus Torvalds [this message]
2007-04-16 19:55   ` Junio C Hamano
2007-04-16 20:20     ` Linus Torvalds
2007-04-20 18:37     ` Christian
2007-04-21  1:03 ` Junio C Hamano
2007-04-21 17:07   ` Christian
2007-04-21 18:28     ` Junio C Hamano
2007-04-22  7:21       ` Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0704161212140.5473@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=crich-ml@beronet.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).