From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: Sven Verdoolaege <skimo@kotnet.org>, git@vger.kernel.org
Subject: Re: t4201-shortlog.sh does bad things to my terminal
Date: Mon, 23 Apr 2007 20:46:21 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.0704232042170.8822@racer.site> (raw)
In-Reply-To: <7vmz0zey30.fsf@assigned-by-dhcp.cox.net>
Hi,
On Mon, 23 Apr 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Mon, 23 Apr 2007, Sven Verdoolaege wrote:
> >
> >> It appears that this message is printing a control character to turn off
> >> echoing, because the terminal appears completely unresponsive
> >> afterwards. Typing "reset" restores the terminal.
> >>
> >> Is this really necessary?
> >
> > On both accounts, no. I did not dream of these bytes being interpreted as
> > control characters.
> >
> > OTOH, you should not need to use --verbose anyway.
>
> I think it's not Sven but you; you should use --quiet in your
> git commit if the log message has annoying characters.
Ah!
I see where this is coming from: c7263d4d "Display the subject of the
commit just made".
Here's the fix:
-- snip --
[PATCH] t4201: Do not display weird characters on the terminal
Now that git-commit got chatty, we have to shut it up again.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
t/t4201-shortlog.sh | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index c27e39c..a48733c 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -15,19 +15,19 @@ commit=$( (echo "Test"; echo) | git commit-tree $tree )
git update-ref HEAD $commit
echo 2 > a1
-git commit -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
+git commit --quiet -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
# test if the wrapping is still valid when replacing all i's by treble clefs.
echo 3 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
# now fsck up the utf8
git repo-config i18n.commitencoding non-utf-8
echo 4 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
echo 5 > a1
-git commit -m "a 12 34 56 78" a1
+git commit --quiet -m "a 12 34 56 78" a1
git shortlog -w HEAD > out
--
1.5.2.rc0.2414.g4e945
next prev parent reply other threads:[~2007-04-23 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 17:03 t4201-shortlog.sh does bad things to my terminal Sven Verdoolaege
2007-04-23 17:29 ` Johannes Schindelin
2007-04-23 17:48 ` Sven Verdoolaege
2007-04-23 18:37 ` Junio C Hamano
2007-04-23 18:46 ` Johannes Schindelin [this message]
2007-04-23 20:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704232042170.8822@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=skimo@kotnet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).