t4201-shortlog.sh does bad things to my terminal

t4201-shortlog.sh does bad things to my terminal

[Sven Verdoolaege]

Running t4201-shortlog.sh in a non-utf8 terminal has some unpleasant effects:

bash-3.00$ xterm -v
XFree86 4.2.99.903(174)
bash-3.00$ locale
LANG=en_US
LC_CTYPE="en_US"
LC_NUMERIC="en_US"
LC_TIME="en_US"
LC_COLLATE=POSIX
LC_MONETARY="en_US"
LC_MESSAGES="en_US"
LC_PAPER="en_US"
LC_NAME="en_US"
LC_ADDRESS="en_US"
LC_TELEPHONE="en_US"
LC_MEASUREMENT="en_US"
LC_IDENTIFICATION="en_US"
LC_ALL=
bash-3.00$ sh ./t4201-shortlog.sh --verbose
Created commit b8ab028: This is a very, very long first line for the commit message to see if it is wrapped correctly
 1 files changed, 1 insertions(+), 1 deletions(-)
Created commit 3da0b85: Thð















(The cursor is now about half way the last line.)

It appears that this message is printing a control character to turn off echoing,
because the terminal appears completely unresponsive afterwards.
Typing "reset" restores the terminal.

Is this really necessary?

skimo

Re: t4201-shortlog.sh does bad things to my terminal

[Johannes Schindelin]

Hi,

On Mon, 23 Apr 2007, Sven Verdoolaege wrote:

> It appears that this message is printing a control character to turn off 
> echoing, because the terminal appears completely unresponsive 
> afterwards. Typing "reset" restores the terminal.
> 
> Is this really necessary?

On both accounts, no. I did not dream of these bytes being interpreted as 
control characters.

OTOH, you should not need to use --verbose anyway.

Ciao,
Dscho

Re: t4201-shortlog.sh does bad things to my terminal

[Sven Verdoolaege]

On Mon, Apr 23, 2007 at 07:29:29PM +0200, Johannes Schindelin wrote:
> OTOH, you should not need to use --verbose anyway.

Well, it does the same thing when I don't use --verbose.
I only noticed because "make test" stopped producing output.

skimo

Re: t4201-shortlog.sh does bad things to my terminal

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Mon, 23 Apr 2007, Sven Verdoolaege wrote:
>
>> It appears that this message is printing a control character to turn off 
>> echoing, because the terminal appears completely unresponsive 
>> afterwards. Typing "reset" restores the terminal.
>> 
>> Is this really necessary?
>
> On both accounts, no. I did not dream of these bytes being interpreted as 
> control characters.
>
> OTOH, you should not need to use --verbose anyway.

I think it's not Sven but you; you should use --quiet in your
git commit if the log message has annoying characters.

Re: t4201-shortlog.sh does bad things to my terminal

[Johannes Schindelin]

Hi,

On Mon, 23 Apr 2007, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Mon, 23 Apr 2007, Sven Verdoolaege wrote:
> >
> >> It appears that this message is printing a control character to turn off 
> >> echoing, because the terminal appears completely unresponsive 
> >> afterwards. Typing "reset" restores the terminal.
> >> 
> >> Is this really necessary?
> >
> > On both accounts, no. I did not dream of these bytes being interpreted as 
> > control characters.
> >
> > OTOH, you should not need to use --verbose anyway.
> 
> I think it's not Sven but you; you should use --quiet in your
> git commit if the log message has annoying characters.

Ah!

I see where this is coming from: c7263d4d "Display the subject of the 
commit just made".

Here's the fix:

-- snip --
[PATCH] t4201: Do not display weird characters on the terminal

Now that git-commit got chatty, we have to shut it up again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 t/t4201-shortlog.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh
index c27e39c..a48733c 100755
--- a/t/t4201-shortlog.sh
+++ b/t/t4201-shortlog.sh
@@ -15,19 +15,19 @@ commit=$( (echo "Test"; echo) | git commit-tree $tree )
 git update-ref HEAD $commit
 
 echo 2 > a1
-git commit -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
+git commit --quiet -m "This is a very, very long first line for the commit message to see if it is wrapped correctly" a1
 
 # test if the wrapping is still valid when replacing all i's by treble clefs.
 echo 3 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\360\235\204\236')" a1
 
 # now fsck up the utf8
 git repo-config i18n.commitencoding non-utf-8
 echo 4 > a1
-git commit -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
+git commit --quiet -m "$(echo "This is a very, very long first line for the commit message to see if it is wrapped correctly" | sed "s/i/1234/g" | tr 1234 '\370\235\204\236')" a1
 
 echo 5 > a1
-git commit -m "a								12	34	56	78" a1
+git commit --quiet -m "a								12	34	56	78" a1
 
 git shortlog -w HEAD > out
 
-- 
1.5.2.rc0.2414.g4e945

Re: t4201-shortlog.sh does bad things to my terminal

[Junio C Hamano]

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> Ah!
>
> I see where this is coming from: c7263d4d "Display the subject of the 
> commit just made".
>
> Here's the fix:

thanks.