From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Schindelin Subject: Re: [PATCH] Add a birdview-on-the-source-code section to the user manual Date: Wed, 9 May 2007 01:10:13 +0200 (CEST) Message-ID: References: <20070508210153.GA3969@diana.vm.bytemark.co.uk> <20070508213158.GB3969@diana.vm.bytemark.co.uk> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323584-322471062-1178665813=:4167" Cc: bfields@citi.umich.edu, junio@cox.net, git@vger.kernel.org To: Karl =?iso-8859-1?Q?Hasselstr=F6m?= X-From: git-owner@vger.kernel.org Wed May 09 01:10:16 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1HlYow-0004Xb-IC for gcvg-git@gmane.org; Wed, 09 May 2007 01:10:14 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969623AbXEHXKK (ORCPT ); Tue, 8 May 2007 19:10:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S969619AbXEHXKJ (ORCPT ); Tue, 8 May 2007 19:10:09 -0400 Received: from mail.gmx.net ([213.165.64.20]:44862 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S969615AbXEHXKG (ORCPT ); Tue, 8 May 2007 19:10:06 -0400 Received: (qmail invoked by alias); 08 May 2007 23:10:04 -0000 Received: from wbgn013.biozentrum.uni-wuerzburg.de (EHLO localhost) [132.187.25.13] by mail.gmx.net (mp046) with SMTP; 09 May 2007 01:10:04 +0200 X-Authenticated: #1490710 X-Provags-ID: V01U2FsdGVkX1+DaXoXm0yDrdedayP9kj1Fvs5zrpqTi0YwMMZDc1 BJ+/0Y0o8ffm5u X-X-Sender: gene099@racer.site In-Reply-To: <20070508213158.GB3969@diana.vm.bytemark.co.uk> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323584-322471062-1178665813=:4167 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Hi, On Tue, 8 May 2007, Karl Hasselström wrote: > On 2007-05-08 23:07:04 +0200, Johannes Schindelin wrote: > > > On Tue, 8 May 2007, Karl Hasselström wrote: > > > > > On 2007-05-08 17:10:47 +0200, Johannes Schindelin wrote: > > > > > > > + char *`, but is actually expected to be a pointer to `unsigned > > > > + char[20]`. This variable will contain the big endian version of the > > > > + 40-character hex string representation of the SHA-1. > > > > > > Either it should be "unsigned char[40]" (or possibly 41 with a > > > terminating \0), or else you shouldn't be talking about > > > hexadecimal since it's just a 20-byte big-endian unsigned integer. > > > (A third possibility is that I'm totally confused.) > > > > It is 40 hex-character, but 20 _byte_. If you have any ideas how to > > formulate that better than I did... > > I think this is less confusing: > > This variable will contain the 160-bit SHA-1. > > It avoids talking of hex, since it's not really stored in hex format > any more than any other binary number with a number of bits divisible > by four. And it avoids saying big-endian, which is not relevant anyway > since we don't use hashes as integers. Well, I do not buy into that. First, we _have_ to say that it is big-endian. It was utterly confusing to _me_ that the hash was not little endian, as I expected on an Intel processor. And I'd rather mention the hex representation (what you see in git-log and git-ls-tree). This helps debugging, believe me. Ciao, Dscho --8323584-322471062-1178665813=:4167--