From: Daniel Barkalow <barkalow@iabervon.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/3] Remotes library, take 4
Date: Sat, 12 May 2007 15:37:30 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705121531480.18541@iabervon.org> (raw)
In-Reply-To: <7vfy61zvtx.fsf@assigned-by-dhcp.cox.net>
On Sat, 12 May 2007, Junio C Hamano wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
> > Updated for recent review. If remote section name starts with '/', it is
> > ignored (like in 1.5.0). If a remote section option has no value, it is
> > also ignored (so it doesn't crash, and to be forward-compatible if we
> > introduce a boolean option later).
> >
> > The struct refspec field and associated variables are spelled "dst".
> >
> > Part 3 is unchanged.
>
> It cannot be left unchanged as it is affected by the dest stuff.
>
> I'll push out a fixed-up one on 'pu' soonish. Let's stabilize
> this a bit without too many resends.
Yeah, I think we agree on how it should be now, and I'm just confusing
myself regenerating patches. Although, possibly, the comment about NULL
value should go into documentation for config_fn_t instead, since it's of
more general applicability than just this.
-Daniel
*This .sig left intentionally blank*
prev parent reply other threads:[~2007-05-12 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 15:45 [PATCH 0/3] Remotes library, take 4 Daniel Barkalow
2007-05-12 19:27 ` Junio C Hamano
2007-05-12 19:37 ` Daniel Barkalow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705121531480.18541@iabervon.org \
--to=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).