* [PATCH 0/3] Remotes library, take 4
@ 2007-05-12 15:45 Daniel Barkalow
2007-05-12 19:27 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Barkalow @ 2007-05-12 15:45 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Updated for recent review. If remote section name starts with '/', it is
ignored (like in 1.5.0). If a remote section option has no value, it is
also ignored (so it doesn't crash, and to be forward-compatible if we
introduce a boolean option later).
The struct refspec field and associated variables are spelled "dst".
Part 3 is unchanged.
-Daniel
*This .sig left intentionally blank*
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Remotes library, take 4
2007-05-12 15:45 [PATCH 0/3] Remotes library, take 4 Daniel Barkalow
@ 2007-05-12 19:27 ` Junio C Hamano
2007-05-12 19:37 ` Daniel Barkalow
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-05-12 19:27 UTC (permalink / raw)
To: Daniel Barkalow; +Cc: git
Daniel Barkalow <barkalow@iabervon.org> writes:
> Updated for recent review. If remote section name starts with '/', it is
> ignored (like in 1.5.0). If a remote section option has no value, it is
> also ignored (so it doesn't crash, and to be forward-compatible if we
> introduce a boolean option later).
>
> The struct refspec field and associated variables are spelled "dst".
>
> Part 3 is unchanged.
It cannot be left unchanged as it is affected by the dest stuff.
I'll push out a fixed-up one on 'pu' soonish. Let's stabilize
this a bit without too many resends.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 0/3] Remotes library, take 4
2007-05-12 19:27 ` Junio C Hamano
@ 2007-05-12 19:37 ` Daniel Barkalow
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Barkalow @ 2007-05-12 19:37 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Sat, 12 May 2007, Junio C Hamano wrote:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>
> > Updated for recent review. If remote section name starts with '/', it is
> > ignored (like in 1.5.0). If a remote section option has no value, it is
> > also ignored (so it doesn't crash, and to be forward-compatible if we
> > introduce a boolean option later).
> >
> > The struct refspec field and associated variables are spelled "dst".
> >
> > Part 3 is unchanged.
>
> It cannot be left unchanged as it is affected by the dest stuff.
>
> I'll push out a fixed-up one on 'pu' soonish. Let's stabilize
> this a bit without too many resends.
Yeah, I think we agree on how it should be now, and I'm just confusing
myself regenerating patches. Although, possibly, the comment about NULL
value should go into documentation for config_fn_t instead, since it's of
more general applicability than just this.
-Daniel
*This .sig left intentionally blank*
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-12 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-12 15:45 [PATCH 0/3] Remotes library, take 4 Daniel Barkalow
2007-05-12 19:27 ` Junio C Hamano
2007-05-12 19:37 ` Daniel Barkalow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).