git-clone tries to cd to a remote repository

git-clone tries to cd to a remote repository

[Tero Roponen]

Hi,

the latest git seems to output a warning every time I
try to clone a repository that is not local:

$ git --version
git version 1.5.2.rc3.27.g43d151

$ git clone git://git.kernel.org/pub/scm/git/git.git
/usr/local/bin/git-clone: line 23: cd: git://git.kernel.org/pub/scm/git/git.git: No such file or directory
Initialized empty Git repository in /home/terrop/repositories/git/.git/
remote: Generating pack...
...

I think the output should be redirected to /dev/null,
but I'm not a shell/git guru...

-- 
Tero Roponen

[PATCH] Fix git-clone buglet for remote case.

[Junio C Hamano]

c2f599e09fd0496413d1744b5b89b9b5c223555d introduced a buglet while
cloning from a remote URL; we forgot to squelch the unnecessary
error message when we try to cd to the given "remote" name,
in order to see if it is a local directory.

Signed-off-by: Junio C Hamano <junkio@cox.net>
---

Tero Roponen <teanropo@jyu.fi> writes:

  > the latest git seems to output a warning every time I
  > try to clone a repository that is not local:
  >
  > $ git --version
  > git version 1.5.2.rc3.27.g43d151
  >
  > $ git clone git://git.kernel.org/pub/scm/git/git.git
  > /usr/local/bin/git-clone: line 23: cd: git://git.kernel.org/pub/scm/git/git.git: No such file or directory

  Yup, thankfully that is harmless but it is ugly and wrong
  nevertheless.  Thanks for the report.

 git-clone.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/git-clone.sh b/git-clone.sh
index 70374aa..fdd354f 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -22,10 +22,10 @@ get_repo_base() {
 		cd "`/bin/pwd`" &&
 		cd "$1" &&
 		{
-			cd .git 2>/dev/null
+			cd .git
 			pwd
 		}
-	)
+	) 2>/dev/null
 }
 
 if [ -n "$GIT_SSL_NO_VERIFY" ]; then
-- 
1.5.2.rc3.27.g43d151