From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Han-Wen Nienhuys <hanwen@xs4all.nl>,
Johannes Sixt <J.Sixt@eudaptics.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Marius Storm-Olsen <marius@trolltech.com>,
git@vger.kernel.org
Subject: [PATCH] Git wrapper: add --redirect-stderr option
Date: Wed, 30 May 2007 04:25:57 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705300407170.4011@racer.site> (raw)
In-Reply-To: <20070530025705.GN7044@spearce.org>
With this option, stderr is redirected to stdout. The short option is '-2'.
Alternatively, you can say '--redirect-stderr=<filename>' to redirect
stderr to a file.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Tue, 29 May 2007, Shawn O. Pearce wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> >
> > BTW Almost any operation I run in git-gui fails, because cat
> > is not found.
>
> That's the stuff that goes into a console and dumps both to
> stdout and stderr. E.g. fetch, push, "compress database".
>
> The issue is Tcl doesn't give me a way to get a pipe to both
> stdout and stderr. I cannot get two pipes, nor can I get a
> single pipe with both stdout+stderr redirected to that pipe.
> Unless I pipe it into another process. Enter `cat`.
>
> Would we consider a "--stderr-to-stdout" long option to git
> itself? Then I could have git-gui do:
>
> git --stderr-to-stdout fetch
>
> and bypass the pipe into cat. Yes, I know, its crap. Welcome
> to Tcl.
How about this?
git.c | 14 ++++++++++++++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/git.c b/git.c
index 53d81e9..72e0539 100644
--- a/git.c
+++ b/git.c
@@ -82,6 +82,20 @@ static int handle_options(const char*** argv, int* argc)
} else if (!strcmp(cmd, "--bare")) {
static char git_dir[PATH_MAX+1];
setenv(GIT_DIR_ENVIRONMENT, getcwd(git_dir, sizeof(git_dir)), 1);
+ } else if (!strcmp(cmd, "-2") ||
+ !strcmp(cmd, "--redirect-stderr")) {
+ if (dup2(1, 2) < 0)
+ return error("Could not redirect stderr: %s",
+ strerror(errno));
+ } else if (!prefixcmp(cmd, "--redirect-stderr=")) {
+ int fd = open(cmd + 18, O_WRONLY | O_CREAT, 0777), ret;
+ if (fd < 0)
+ return error("Could not open %s", cmd + 18);
+ ret = dup2(fd, 2);
+ close(fd);
+ if (ret < 0)
+ return error("Could not redirect stderr: %s",
+ strerror(errno));
} else {
fprintf(stderr, "Unknown option: %s\n", cmd);
usage(git_usage_string);
--
1.5.2.2642.gc8bae-dirty
next prev parent reply other threads:[~2007-05-30 3:27 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 1:13 GIT on MinGW problem Aaron Gray
2007-05-12 1:17 ` Junio C Hamano
2007-05-12 2:25 ` Aaron Gray
2007-05-12 3:30 ` Han-Wen Nienhuys
2007-05-25 8:49 ` Johannes Sixt
2007-05-25 9:45 ` Marco Costalba
2007-05-25 10:20 ` Johannes Schindelin
2007-05-25 11:07 ` Johannes Sixt
2007-05-26 19:42 ` Han-Wen Nienhuys
2007-05-26 22:17 ` Johannes Schindelin
2007-05-27 6:56 ` Han-Wen Nienhuys
2007-05-27 10:52 ` Johannes Schindelin
2007-05-27 17:04 ` Han-Wen Nienhuys
2007-05-28 16:54 ` Nix
2007-05-27 20:44 ` Han-Wen Nienhuys
[not found] ` <Pine.LNX.4.64.0705272213350.4648@racer.site>
[not found] ` <f329bf540705271417k1874c1f2u3acc98dc25e058b9@mail.gmail.com>
2007-05-27 21:26 ` Johannes Schindelin
2007-05-25 21:37 ` Aaron Gray
2007-05-26 19:41 ` Han-Wen Nienhuys
2007-05-26 22:26 ` Johannes Schindelin
2007-05-26 22:39 ` Junio C Hamano
2007-05-26 22:45 ` Johannes Schindelin
2007-05-26 22:53 ` Han-Wen Nienhuys
2007-05-26 23:47 ` Jakub Narebski
2007-05-27 6:30 ` Han-Wen Nienhuys
2007-05-27 6:39 ` Shawn O. Pearce
2007-05-27 7:02 ` Han-Wen Nienhuys
2007-05-27 7:21 ` Steven Grimm
2007-05-27 9:09 ` Jakub Narebski
2007-05-27 23:18 ` Han-Wen Nienhuys
2007-05-28 0:04 ` Johannes Schindelin
2007-05-28 0:31 ` Han-Wen Nienhuys
2007-05-27 10:46 ` Johannes Schindelin
2007-05-27 18:50 ` Han-Wen Nienhuys
2007-05-27 19:52 ` GIT on MinGW, with tcltk for gitk Han-Wen Nienhuys
2007-05-27 20:39 ` Aaron Gray
2007-05-27 21:19 ` Han-Wen Nienhuys
2007-05-27 21:24 ` Aaron Gray
2007-05-27 21:39 ` Aaron Gray
2007-05-27 21:55 ` Han-Wen Nienhuys
2007-05-27 22:22 ` Aaron Gray
2007-05-27 22:28 ` Han-Wen Nienhuys
2007-05-27 22:56 ` GIT on MinGW - No symbolic links support Aaron Gray
2007-05-27 23:56 ` Johannes Schindelin
2007-05-29 7:11 ` Johannes Sixt
2007-05-27 22:22 ` GIT on MinGW, with tcltk for gitk Han-Wen Nienhuys
2007-05-29 10:54 ` GIT on MinGW problem Johannes Sixt
2007-05-29 11:45 ` Marius Storm-Olsen
2007-05-29 12:10 ` Johannes Sixt
2007-05-29 14:29 ` Han-Wen Nienhuys
2007-05-29 14:49 ` Johannes Sixt
2007-05-29 12:11 ` Johannes Schindelin
2007-05-29 13:05 ` Marius Storm-Olsen
2007-05-29 13:24 ` Johannes Sixt
2007-05-29 14:36 ` Marius Storm-Olsen
2007-05-29 13:47 ` Johannes Schindelin
2007-05-29 14:13 ` Johannes Sixt
2007-05-29 15:28 ` Nguyen Thai Ngoc Duy
2007-05-29 15:47 ` Johannes Sixt
2007-05-29 18:45 ` Nguyen Thai Ngoc Duy
2007-05-30 3:03 ` [PATCH] Make git-k an alias to gitk Johannes Schindelin
2007-05-30 7:06 ` Johannes Sixt
2007-05-30 2:16 ` GIT on MinGW problem Han-Wen Nienhuys
2007-05-30 2:39 ` Johannes Schindelin
2007-05-30 2:57 ` Shawn O. Pearce
2007-05-30 3:25 ` Johannes Schindelin [this message]
2007-05-30 3:38 ` [PATCH] Git wrapper: add --redirect-stderr option Shawn O. Pearce
2007-05-30 3:45 ` Johannes Schindelin
2007-05-30 3:53 ` Shawn O. Pearce
2007-05-30 4:12 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705300407170.4011@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=J.Sixt@eudaptics.com \
--cc=git@vger.kernel.org \
--cc=hanwen@xs4all.nl \
--cc=marius@trolltech.com \
--cc=pclouds@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).