From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: "Kristian Høgsberg" <hoegsberg@gmail.com>, git@vger.kernel.org
Subject: [PATCH] Update to SubmittingPatches
Date: Sun, 3 Jun 2007 01:46:47 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706030145420.4046@racer.site> (raw)
In-Reply-To: <7v8xb2qj37.fsf@assigned-by-dhcp.cox.net>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1716 bytes --]
Make people aware of our testsuite, and of non-ASCII encodings.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Sat, 2 Jun 2007, Junio C Hamano wrote:
> Junio C Hamano <junkio@cox.net> writes:
>
> > Kristian Høgsberg <hoegsberg@gmail.com> writes:
> >
> >> Encode ' ' using '=20' even though rfc2047 allows using '_' for
> >> readability..
> >
> > Thanks.
> >
> > Your message was marked as iso-8859-1 even though it was utf-8
> > (your signed-off-by line), so I'll fix it up with your From:
> > header.
>
> Oh, another thing. Before you submit a patch, make sure the
> whole testsuite in t/ passes by running "make test".
We should remind people of both.
Documentation/SubmittingPatches | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index b5f2ecd..b6e5847 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -14,6 +14,8 @@ Checklist (and a short version for the impatient):
commit message (or just use the option "-s" when
committing) to confirm that you agree to the Developer's
Certificate of Origin
+ - make sure that you have tests for the bug you are fixing
+ - make sure that the test suit passes after your commit
Patch:
@@ -33,6 +35,8 @@ Checklist (and a short version for the impatient):
- if you change, add, or remove a command line option or
make some other user interface change, the associated
documentation should be updated as well.
+ - if your name is not writable in ASCII, make sure that
+ you send off a message in the correct encoding.
Long version:
--
1.5.2.2663.gd77e7-dirty
prev parent reply other threads:[~2007-06-03 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 21:08 [PATCH] Use =20 when rfc2047 encoding spaces Kristian Høgsberg
2007-06-01 21:12 ` Jeffrey C. Ollie
2007-06-02 18:51 ` Junio C Hamano
2007-06-02 18:58 ` Junio C Hamano
2007-06-03 0:46 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706030145420.4046@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=hoegsberg@gmail.com \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).