From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: Junio C Hamano <gitster@pobox.com>,
Jakub Narebski <jnareb@gmail.com>,
git@vger.kernel.org
Subject: [PATCH] filter-branch: use $(($i+1)) instead of $((i+1))
Date: Wed, 6 Jun 2007 16:24:07 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706061620540.4046@racer.site> (raw)
In-Reply-To: <20070605103421.GB16160@diku.dk>
The expression $((i+1)) is not portable at all: even some bash versions
do not grok it. So do not use it.
Noticed by Jonas Fonseca.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
On Tue, 5 Jun 2007, Jonas Fonseca wrote:
> Junio C Hamano <gitster@pobox.com> wrote Tue, Jun 05, 2007:
> > Jonas Fonseca <fonseca@diku.dk> writes:
> >
> > > $ git filter-branch H2
> > > /home/fonseca/bin/git-filter-branch: 386: arith: syntax error: "i+1"
> > > $
> > >
> > > A possible fix that makes the test pass for me.
> >
> > [...]
> >
> > The portable ones we already have in the code say things like:
> >
> > msgnum=$(($msgnum+1))
>
> Yes, I should have investigated before sending.
>
> > The one in filter-branch that bit you does not dereference 'i'.
> > I am reasonably sure if you fix it to read:
> >
> > i=$(( $i+1 ))
> >
> > dash would grok it.
>
> This works here. Even without the spaces.
Voila.
git-filter-branch.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index 6807782..f89cfe1 100644
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -334,7 +334,7 @@ test $commits -eq 0 && die "Found nothing to rewrite"
i=0
while read commit; do
- i=$((i+1))
+ i=$(($i+1))
printf "$commit ($i/$commits) "
git-read-tree -i -m $commit
--
1.5.2.1.2656.g1921f
next prev parent reply other threads:[~2007-06-06 15:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 0:31 [PATCH] Add git-filter-branch Johannes Schindelin
2007-06-03 0:46 ` Jakub Narebski
2007-06-03 0:50 ` Johannes Schindelin
2007-06-03 10:28 ` Jakub Narebski
2007-06-03 18:36 ` Steven Grimm
2007-06-03 23:07 ` Johannes Schindelin
2007-06-05 10:18 ` Jonas Fonseca
2007-06-05 10:26 ` David Kastrup
2007-06-05 10:30 ` Junio C Hamano
2007-06-05 10:34 ` Jonas Fonseca
2007-06-05 13:55 ` Johannes Schindelin
2007-06-06 15:24 ` Johannes Schindelin [this message]
2007-06-04 7:18 ` Johannes Sixt
2007-06-04 7:59 ` Johannes Sixt
2007-06-04 16:11 ` Johannes Schindelin
2007-06-04 16:34 ` Johannes Sixt
2007-06-04 17:55 ` Johannes Schindelin
2007-06-05 7:01 ` Johannes Sixt
2007-06-05 15:58 ` Johannes Schindelin
2007-06-06 7:43 ` Johannes Sixt
2007-06-06 8:17 ` Junio C Hamano
2007-06-06 15:00 ` Johannes Schindelin
2007-06-06 15:22 ` Johannes Sixt
2007-06-06 17:59 ` Johannes Schindelin
2007-06-06 15:36 ` [PATCH] filter-branch: also don't fail in map() if a commit cannot be mapped Johannes Sixt
2007-06-06 17:50 ` Johannes Schindelin
2007-06-06 18:38 ` [PATCH v2] " Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706061620540.4046@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).