From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johan Herland <johan@herland.net>
Subject: Re: [PATCH] Introduce light weight commit annotations
Date: Tue, 12 Jun 2007 18:28:19 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706121825460.4059@racer.site> (raw)
In-Reply-To: <7v4plf5qxp.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 10 Jun 2007, Junio C Hamano wrote:
> With the normal tree parser, the lookup for
> "refs/annotations/commit:??/?{38}" you have in your code would open one
> tree (the commit's tree), find the one with leading 2 hexdigits you
> would want among up to 256 entries with linear search (see
> tree-walk.c::find_tree_entry()), open that entry which is another tree,
> and do the same linear search to find the entry with the remaining 38
> hexdigits. Finding annotation for commit 0000abcd... is much less
> expensive than ffff4567...
Okay, I did not find a proper solution. commit->file name via "s/../&\//g"
is too ugly. But then, I really hope that packv4 becomes unvapourware at
some stage (for other reasons), and that _should_ help these issues.
Hmm.
Ciao,
Dscho
next prev parent reply other threads:[~2007-06-12 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 17:55 [PATCH] Introduce light weight commit annotations Johannes Schindelin
2007-06-10 13:14 ` Johan Herland
2007-06-10 18:56 ` Johannes Schindelin
2007-06-10 19:20 ` Johan Herland
2007-06-10 19:53 ` Johannes Schindelin
2007-06-10 22:11 ` Junio C Hamano
2007-06-10 23:00 ` Johannes Schindelin
2007-06-10 23:29 ` Junio C Hamano
2007-06-11 10:25 ` Johannes Schindelin
2007-06-12 17:28 ` Johannes Schindelin [this message]
2007-06-10 22:58 ` Alex Riesen
2007-06-10 23:20 ` Alex Riesen
2007-06-11 1:11 ` Junio C Hamano
2007-06-11 2:09 ` Nicolas Pitre
2007-06-11 7:24 ` Alex Riesen
2007-06-11 7:43 ` Junio C Hamano
2007-06-11 8:05 ` Alex Riesen
2007-06-11 10:22 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706121825460.4059@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).