From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>
Cc: Marco Costalba <mcostalba@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
"Shawn O. Pearce" <spearce@spearce.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: That improved git-gui blame viewer..
Date: Wed, 13 Jun 2007 18:05:55 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706131804080.4059@racer.site> (raw)
In-Reply-To: <200706131854.59605.Josef.Weidendorfer@gmx.de>
Hi,
On Wed, 13 Jun 2007, Josef Weidendorfer wrote:
> opt->diff is set to 1 in setup_revisions() whenever
> diff_opt_parse() parses an option. And "-z" is
> parsed in diff_opt_parse().
>
> In cd2bdc, Linus write in the commit log
>
> - make setup_revision set a flag (revs->diff) if the diff-related
> arguments were used. This allows "git log" to decide whether it wants
> to show diffs or not.
>
> So why is "-z" regarded as tree-diff related, leading to calculating diffs?
Because it changes the behaviour of a diff. As far as I can tell, the line
termination does not have any effect on any output _except_ the diff
output.
So, I should have realized earlier that "git-log -z" _without_ anything in
the way of "-p", "--stat" or friends does not make sense at all.
Ciao,
Dscho
next prev parent reply other threads:[~2007-06-13 17:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-09 18:26 That improved git-gui blame viewer Linus Torvalds
2007-06-09 18:29 ` Junio C Hamano
2007-06-11 6:42 ` Shawn O. Pearce
2007-06-11 15:46 ` Linus Torvalds
2007-06-11 16:05 ` Junio C Hamano
2007-06-12 6:16 ` Marco Costalba
2007-06-12 6:52 ` Junio C Hamano
2007-06-12 11:27 ` Marco Costalba
2007-06-12 11:58 ` Marco Costalba
2007-06-12 13:53 ` Shawn O. Pearce
2007-06-12 19:14 ` Junio C Hamano
2007-06-13 11:11 ` Marco Costalba
2007-06-13 12:44 ` Marco Costalba
2007-06-13 12:45 ` Johannes Schindelin
2007-06-13 14:08 ` Marco Costalba
2007-06-13 14:58 ` Johannes Schindelin
2007-06-13 16:18 ` Marco Costalba
2007-06-13 16:40 ` Johannes Schindelin
2007-06-13 16:27 ` Josef Weidendorfer
2007-06-13 16:50 ` Johannes Schindelin
2007-06-13 16:54 ` Josef Weidendorfer
2007-06-13 17:05 ` Johannes Schindelin [this message]
2007-06-13 18:17 ` Josef Weidendorfer
2007-06-13 18:34 ` Johannes Schindelin
2007-06-13 17:17 ` Junio C Hamano
2007-06-14 5:17 ` Shawn O. Pearce
2007-06-13 23:20 ` Jakub Narebski
2007-06-14 6:24 ` Marco Costalba
2007-06-13 11:03 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706131804080.4059@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=Josef.Weidendorfer@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcostalba@gmail.com \
--cc=spearce@spearce.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).