From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFH] pp_header(): work around possible memory corruption
Date: Sun, 24 Jun 2007 00:32:58 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706240031220.4059@racer.site> (raw)
In-Reply-To: <7vps3w4g9x.fsf@assigned-by-dhcp.pobox.com>
Hi,
On Fri, 15 Jun 2007, Junio C Hamano wrote:
> At least the older humongous pretty_print_commit() got separated into
> manageable chunks, and I was happy. I was just too lazy when
> refactoring the code and stopped there.
Understandable.
> The right fix is to propagate the "realloc as needed" callchain into
> add_user_info(), instead of having "this should be enough" there.
> These two you touched are the only two callsite of that static function.
I had a go at this, but unfortunately I do not understand enough of what
is going on there. For example, add_rfc2047() sometimes quotes some text.
I have no idea what a conservative estimate of the growth is, so I cannot
continue there.
Sorry,
Dscho
prev parent reply other threads:[~2007-06-23 23:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-15 12:19 [PATCH/RFH] pp_header(): work around possible memory corruption Johannes Schindelin
2007-06-16 5:31 ` Junio C Hamano
2007-06-19 0:19 ` Johannes Schindelin
2007-06-23 23:32 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706240031220.4059@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).