From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <J.Sixt@eudaptics.com>, git@vger.kernel.org
Subject: Re: [PATCH] git add: respect core.filemode even with unmerged entries in the index
Date: Fri, 29 Jun 2007 11:06:11 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0706291103470.4438@racer.site> (raw)
In-Reply-To: <7vir97f98o.fsf@assigned-by-dhcp.pobox.com>
Hi,
On Fri, 29 Jun 2007, Junio C Hamano wrote:
> Hmph.
>
> * Are you sure about (1-pos)?
>
> * I _think_ we would want to favor our stage (i.e. #2)
Hmph back.
I _thought_ that our stage is #1, not even bothering to check the
documentation. But it seems that you are right.
So your code looks fine to me, except that I would move the whole
get_index_entry_for_file_even_if_the_entry_is_unmerged(name, namelen)
code into its own function.
Want me to prepare a patch? If so, I'll do it tonight, since I will be
occupied the rest of the (working) day.
Ciao,
Dscho
next prev parent reply other threads:[~2007-06-29 10:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 6:40 most commonly used git commands? Michael S. Tsirkin
2007-06-25 7:10 ` Junio C Hamano
2007-06-25 7:17 ` Michael S. Tsirkin
2007-06-25 7:48 ` Junio C Hamano
2007-06-28 2:17 ` Martin Langhoff
2007-06-28 2:30 ` Josh Triplett
2007-06-25 7:51 ` Johannes Schindelin
2007-06-28 8:52 ` Alex Riesen
2007-06-28 13:08 ` Johannes Schindelin
2007-06-28 13:54 ` Johannes Sixt
2007-06-28 14:07 ` Johannes Schindelin
2007-06-28 14:29 ` Johannes Sixt
2007-06-28 14:49 ` Johannes Sixt
2007-06-28 17:02 ` [PATCH] git add: respect core.filemode even with unmerged entries in the index Johannes Schindelin
2007-06-29 6:57 ` [PATCH] git add: respect core.filemode even with unmerged entriesin " Johannes Sixt
2007-06-29 10:07 ` Johannes Schindelin
2007-06-29 10:20 ` Junio C Hamano
2007-06-29 17:32 ` [PATCH] git add: respect core.filemode with unmerged entries Johannes Schindelin
2007-06-29 8:36 ` [PATCH] git add: respect core.filemode even with unmerged entries in the index Junio C Hamano
2007-06-29 10:06 ` Johannes Schindelin [this message]
2007-06-30 13:14 ` most commonly used git commands? Alex Riesen
2007-06-30 14:31 ` Johannes Schindelin
2007-06-30 22:35 ` Alex Riesen
2007-07-01 9:16 ` Jan Hudec
2007-07-01 16:49 ` Alex Riesen
2007-06-28 1:37 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706291103470.4438@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=J.Sixt@eudaptics.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).