t7004-tag.sh fails (old gpg?)

t7004-tag.sh fails (old gpg?)

[Sven Verdoolaege]

t7004-tag.sh fails for me:

* expecting success: 
        git-tag -s -m "A signed tag message" signed-tag &&
        get_tag_msg signed-tag >actual &&
        git-diff expect actual

gpg: Warning: using insecure memory!
gpg: [don't know]: invalid packet (ctb=00)
gpg: read_keyblock: read error: invalid packet
gpg: enum_keyblocks failed: invalid keyring
gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
gpg: signing failed: invalid keyring
failed to sign the tag with GPG.
* FAIL 49: creating a signed tag with -m message should succeed

                git-tag -s -m "A signed tag message" signed-tag &&
                get_tag_msg signed-tag >actual &&
                git-diff expect actual

I see that you alread check for presence of gpg, but maybe
you should also check that it is recent enough.
This is the version I have:

bash-3.00$ gpg --version
gpg (GnuPG) 1.0.6
Copyright (C) 2001 Free Software Foundation, Inc.
This program comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it
under certain conditions. See the file COPYING for details.

Home: ~/.gnupg
Supported algorithms:
Cipher: 3DES, CAST5, BLOWFISH, RIJNDAEL, RIJNDAEL192, RIJNDAEL256, TWOFISH
Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA, ELG
Hash: MD5, SHA1, RIPEMD160

skimo

Re: t7004-tag.sh fails (old gpg?)

[Johannes Schindelin]

Hi,

On Sun, 1 Jul 2007, Sven Verdoolaege wrote:

> gpg: Warning: using insecure memory!
> gpg: [don't know]: invalid packet (ctb=00)
> gpg: read_keyblock: read error: invalid packet
> gpg: enum_keyblocks failed: invalid keyring
> gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
> gpg: signing failed: invalid keyring

That means that gpg somehow barfs on the keyring. I somehow had the 
impression that the keyrings were binary compatible on different 
systems... What system do you have?

> bash-3.00$ gpg --version
> gpg (GnuPG) 1.0.6

It is 1.4.5 here.

> Pubkey: RSA, RSA-E, RSA-S, ELG-E, DSA, ELG

AFAIK DSA should suffice.

Ciao,
Dscho

Re: t7004-tag.sh fails (old gpg?)

[Sven Verdoolaege]

On Sun, Jul 01, 2007 at 03:09:06PM +0100, Johannes Schindelin wrote:
> Hi,
> 
> On Sun, 1 Jul 2007, Sven Verdoolaege wrote:
> 
> > gpg: Warning: using insecure memory!
> > gpg: [don't know]: invalid packet (ctb=00)
> > gpg: read_keyblock: read error: invalid packet
> > gpg: enum_keyblocks failed: invalid keyring
> > gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
> > gpg: signing failed: invalid keyring
> 
> That means that gpg somehow barfs on the keyring. I somehow had the 
> impression that the keyrings were binary compatible on different 
> systems... What system do you have?

A regular (old) Linux system:

Linux greensroom 2.4.23 #3 SMP Mon Jan 5 14:14:32 CET 2004 i686 unknown unknown GNU/Linux

skimo

Re: t7004-tag.sh fails (old gpg?)

[Carlos Rica]

2007/7/1, Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> On Sun, 1 Jul 2007, Sven Verdoolaege wrote:
>
> > gpg: Warning: using insecure memory!
> > gpg: [don't know]: invalid packet (ctb=00)
> > gpg: read_keyblock: read error: invalid packet
> > gpg: enum_keyblocks failed: invalid keyring
> > gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
> > gpg: signing failed: invalid keyring
>
> That means that gpg somehow barfs on the keyring. I somehow had the
> impression that the keyrings were binary compatible on different
> systems... What system do you have?
>
> > bash-3.00$ gpg --version
> > gpg (GnuPG) 1.0.6
>
> It is 1.4.5 here.

I have gpg (GnuPG) 1.4.1 here, in the system I used to generate the key.

Re: t7004-tag.sh fails (old gpg?)

[Carlos Rica]

> > On Sun, 1 Jul 2007, Sven Verdoolaege wrote:
> >
> > > gpg: Warning: using insecure memory!
> > > gpg: [don't know]: invalid packet (ctb=00)
> > > gpg: read_keyblock: read error: invalid packet
> > > gpg: enum_keyblocks failed: invalid keyring
> > > gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
> > > gpg: signing failed: invalid keyring

I don't know if it could be due to the deleted t/t7004/trustdb.gpg file,
you can check the same including it (if you didn't get it already):
http://article.gmane.org/gmane.comp.version-control.git/51271

Can you verify the other tags, like those from Junio on each version?

Re: t7004-tag.sh fails (old gpg?)

[Sven Verdoolaege]

On Sun, Jul 01, 2007 at 06:06:06PM +0200, Carlos Rica wrote:
> >> On Sun, 1 Jul 2007, Sven Verdoolaege wrote:
> >>
> >> > gpg: Warning: using insecure memory!
> >> > gpg: [don't know]: invalid packet (ctb=00)
> >> > gpg: read_keyblock: read error: invalid packet
> >> > gpg: enum_keyblocks failed: invalid keyring
> >> > gpg: skipped `C O Mitter <committer@example.com>': invalid keyring
> >> > gpg: signing failed: invalid keyring
> 
> I don't know if it could be due to the deleted t/t7004/trustdb.gpg file,
> you can check the same including it (if you didn't get it already):
> http://article.gmane.org/gmane.comp.version-control.git/51271

Doesn't seem to have any effect.

> Can you verify the other tags, like those from Junio on each version?

Apparently...

bash-3.00$ git-cat-file blob junio-gpg-pub | gpg --import
gpg: Warning: using insecure memory!
gpg: key F3119B9A: public key imported
gpg: Total number processed: 1
gpg:               imported: 1
bash-3.00$ git-verify-tag v1.5.2-rc2
gpg: Warning: using insecure memory!
gpg: Signature made Sun 06 May 2007 10:08:26 AM CEST using DSA key ID F3119B9A
gpg: Good signature from "[image of size 1532]"
gpg:                 aka "Junio C Hamano <junkio@cox.net>"
Could not find a valid trust path to the key.  Let's see whether we
can assign some missing owner trust values.

No path leading to one of our keys found.

gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
gpg: Fingerprint: 3565 2A26 2040 E066 C9A7  4A7D C0C6 D9A4 F311 9B9A
bash-3.00$ 

skimo

Re: t7004-tag.sh fails (old gpg?)

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 556 bytes --]

Hi,

On Sun, 1 Jul 2007, Sven Verdoolaege wrote:

> On Sun, Jul 01, 2007 at 06:06:06PM +0200, Carlos Rica wrote:
>
> > Can you verify the other tags, like those from Junio on each version?
> 
> Apparently...

Could you please try to import the attached keys into a new keyring? IOW

	$ mkdir test-gpg
	$ chown go-rwx test-gpg
	$ export GNUPGHOME=$(pwd)/test-gpg
	$ gpg --import pubkeys.asc

And send me the resulting pubring.gpg and secring.gpg?

If you have a little more time, you could also put them in t/t7004/, and 
check t7004-tag.sh...

Ciao,
Dscho

[-- Attachment #2: Type: TEXT/plain, Size: 1712 bytes --]

-----BEGIN PGP PUBLIC KEY BLOCK-----
Version: GnuPG v1.4.5 (GNU/Linux)

mQGiBEZnyykRBACzCPjIpTYNL7Y2tQqlEGTTDlvZcWNLjF5f7ZzuyOqNOidLUgFD
36qch1LZLSZkShdR3Gae+bsolyjxrlFuFP0eXRPMtqK20aLw7WZvPFpEV1ThMne+
PRJjYrvghWw3L0VVIAIZ8GXwrVBuU99uEjHEI0ojYloOvFc2jVPgSaoBvwCg48Tj
fol2foSoJa7XUu9yAL8szg8D/RUsTzNF+I9hSRHl7MYKFMYoKEY9BDgrgAujp7YY
8qdGsiUb0Ggyzp2kRjZFt4lpcvKhGfHn5GEjmtk+fRbD5qPfMqKFW+T0NPfYlYmL
JJ4fs4qZ8Lx7x6iG6X51u+YNwsQuIGjMCC3CeNi3F7or651kkNYASbaQ1NROkCIN
NudyA/0aasvoZUoNJAc2cP5Ifs6WhXMWLfMR2p2XbfKwKNYneec60usnSComcKqh
sJVk0Gytvr3FOYVhRkXnKAbx+0W2urFP8OFVBTEKO6Ts2VygWGgneQYoHnqzwlUE
yjOjlr+lyf7u2s/KAxpKA6jnttEdRZAmzWkhuox1wwAUkr27/bQiQyBPIE1pdHRl
ciA8Y29tbWl0dGVyQGV4YW1wbGUuY29tPoheBBMRAgAeBQJGZ8spAhsDBgsJCAcD
AgMVAgMDFgIBAh4BAheAAAoJEBO29R7N3kMNdB0An0npiVm5p1HoQjKV4PrHPbrp
b0ahAKC/3JbGwl1vs0Wdno7vY+KBKDaUYLkCDQRGZ8tOEAgAzrl5P1Pr6CDR8mf5
DGGzcUUM+PEroA4FLdKJ5ZaZc7qy1lmmW9vuvb6xdinwcwee2c5fdNE+iUjHV2x2
S/dbfDzJTN/0uajZcw+xnf+KxZ0Rs4gDSs7cHXHBtA7u8ShYd4Hu7JggXpiwgfSk
yrGQiZyLAHW2ck8H07Go8eUP8fLIeva+iPqeYQZo9BaPz92R/J6debpeY1lRkv+y
WTq1GE3C/hxbdBAuHf2duLP2uq9kwoVdfzCRjgV1CQmMIbCrMb7vIlzIe96bb3+K
r/+NEtmB2I3wHBXcwJMnIOnz9Zv933KNlxSbVF23BGLB+F9D7OanKymbs7Eg18fr
mt/t/wAEDQgAtGIxGz944Pn2OtheY9JlBRuIAuVskm24/Zz03dZnk6CuEOIBb5IM
g36GAPKcn1vsLZ0TfE1q53jNpcAAXjgngnRsCjZm1mglqPD4ZfBpl+Hhnuc80fAR
xsUPj+5c8KP2M+Rws4moaZRjVpd3KCi3ceflT/OjwnE9DzdhslCGTMA5n8cajAs2
oqAaQssefVf2prLQLGV9NB4Q3lFnKXdvipHMaAYAsW+iF7JkhTDVNuNGlufeSqUm
igRBjTZXBcVd8sj8vDOCWKUfqxJyS+zRYcotn7QvpvcKAkc3ZGxntDHAIGLVp6ay
+vrkV4Ren8BjFobl25Ruy6Abw+CgnTpuwYhJBBgRAgAJBQJGZ8tOAhsMAAoJEBO2
9R7N3kMNwewAoJoZ/yJWSrCXX08A/q8KSX4ZfoBDAJ0Yxei/DHK9m5lXc2MPkMoK
glpIKw==
=XD5b
-----END PGP PUBLIC KEY BLOCK-----

Re: t7004-tag.sh fails (old gpg?)

[Sven Verdoolaege]

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

On Sun, Jul 01, 2007 at 07:06:43PM +0100, Johannes Schindelin wrote:
> And send me the resulting pubring.gpg and secring.gpg?

Attached.

> If you have a little more time, you could also put them in t/t7004/, and 
> check t7004-tag.sh...

Different...  (assuming I understand your request correctly)

* expecting success: 
        git-tag -s -m "A signed tag message" signed-tag &&
        get_tag_msg signed-tag >actual &&
        git-diff expect actual

gpg: Warning: using insecure memory!
gpg: skipped `C O Mitter <committer@example.com>': secret key not available
gpg: signing failed: secret key not available
failed to sign the tag with GPG.
* FAIL 49: creating a signed tag with -m message should succeed

                git-tag -s -m "A signed tag message" signed-tag &&
                get_tag_msg signed-tag >actual &&
                git-diff expect actual

bash-3.00$ git diff
diff --git a/t/t7004/pubring.gpg b/t/t7004/pubring.gpg
index 83855fa..20e89c6 100644
Binary files a/t/t7004/pubring.gpg and b/t/t7004/pubring.gpg differ
diff --git a/t/t7004/secring.gpg b/t/t7004/secring.gpg
index d831cd9..e69de29 100644
Binary files a/t/t7004/secring.gpg and b/t/t7004/secring.gpg differ

skimo

[-- Attachment #2: pubring.gpg --]
[-- Type: application/octet-stream, Size: 1172 bytes --]

[-- Attachment #3: secring.gpg --]
[-- Type: text/plain, Size: 0 bytes --]

Re: t7004-tag.sh fails (old gpg?)

[Johannes Schindelin]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 786 bytes --]

Hi,

On Sun, 1 Jul 2007, Sven Verdoolaege wrote:

> On Sun, Jul 01, 2007 at 07:06:43PM +0100, Johannes Schindelin wrote:
> > And send me the resulting pubring.gpg and secring.gpg?
> 
> Attached.

Thanks.

> > If you have a little more time, you could also put them in t/t7004/, and 
> > check t7004-tag.sh...
> 
> Different...  (assuming I understand your request correctly)
> 
> * expecting success: 
>         git-tag -s -m "A signed tag message" signed-tag &&
>         get_tag_msg signed-tag >actual &&
>         git-diff expect actual
> 
> gpg: Warning: using insecure memory!
> gpg: skipped `C O Mitter <committer@example.com>': secret key not available
> gpg: signing failed: secret key not available

Aargh! I am a complete moron. Attached also the private key now.

Ciao,
Dscho

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: TEXT/plain; charset=utf-8; name=seckeys.asc, Size: 1237 bytes --]

•\x01»\x04FgË)\x11\x04\0³\bøÈ¥6\r/¶6µ
¥\x10dÓ\x0e[ÙqcKŒ^_íœîÈê:'KR\x01Cߪœ‡RÙ-&dJ\x17QÜfžù»(—(ñ®Qn\x14ý\x1e]\x13̶¢¶Ñ¢ðífo<ZDWTá2w¾=\x12cb»à…l7/EU \x02\x19ðeð­PnSßn\x121Ä#J#bZ\x0e¼W6SàIª\x01¿\0 ãÄã~‰v~„¨%®×Rïr\0¿,Î\x0f\x03ý\x15,O3EøaI\x11åìÆ
\x14Æ((F=\x048+€\v£§¶\x18ò§F²%^[Ðh2Ν¤F6E·‰irò¡\x19ñçäa#šÙ>}\x16Ãæ£ß2¢…[äô4÷Ø•‰‹$ž\x1f³Š™ð¼{Ǩ†é~u»æ\rÂÄ. hÌ\b-ÂxØ·\x17º+ëdÖ\0I¶ÔÔN"\r6çr\x03ý\x1ajËèeJ\r$\a6pþH~Ζ…s\x16-ó\x11ڝ—mò°(Ö'yç:Òë'H*&pª¡°•dÐl­¾½Å9…aFEç(\x06ñûE¶º±OðáU\x051
;¤ìÙ\ Xh'y\x06(\x1ez³ÂU\x04Ê3£–¿¥ÉþîÚÏÊ\x03\x1aJ\x03¨ç¶Ñ\x1dE&Íi!ºŒuÃ\0\x14’½»ý\0\0ŸtÄ̤u§\x1cQù\x1dÝ\x1eáižwÚ´Â\x03\v“´"C O Mitter <committer@example.com>ˆ^\x04\x13\x11\x02\0\x1e\x05\x02FgË)\x02^[\x03\x06\v	\b\a\x03\x02\x03\x15\x02\x03\x03\x16\x02\x01\x02\x1e\x01\x02\x17€\0
	\x10\x13¶õ\x1eÍÞC\rt\x1d\0 ½Ùÿ°:´äncÄ\x7f뾨\x0fÆ¿ qC\0ŸC]¼%p¢ÜÊL\aËHØ©¨×›X‚y\x02=\x04FgËN\x10\b\0ιy?Sëè Ñògù\fa³qE\føñ+ \x0e\x05-҉喙sº²ÖY¦[Ûî½¾±v)ðs\ažÙÎ_tÑ>‰HÇWlvK÷[|<ÉLßô¹¨Ùs\x0f±ÿŠÅ\x11³ˆ\x03JÎÜ\x1dqÁ´\x0eîñ(Xwîì˜ ^˜°ô¤Ê±‰œ‹\0u¶rO\aÓ±¨ñå\x0fñòÈzö¾ˆúža\x06hô\x16ÏÝ‘üžyº^cYQ’ÿ²Y:µ\x18MÂþ\x1c[t\x10.\x1dý¸³öº¯dÂ…]\x7f0‘Ž\x05u		Œ!°«1¾ï"\È{Þ›o\x7fŠ¯ÿ\x12ف؍ð\x1c\x15ÜÀ“' éóõ›ýßr—\x14›T]·\x04bÁø_Cìæ§+)›³± ×Çëšßíÿ\0\x04\r\b\0´b1^[?xàùö:Ø^cÒe\x05^[ˆ\x02ål’m¸ýœôÝÖg“ ®\x10â\x01o’\fƒ~†\0òœŸ[ì-\x13|MjçxÍ¥À\0^8'‚tl
6fÖh%¨ðøeði—áážç<Ñð\x11ÆÅ\x0fî\ð£ö3äp³‰¨i”cV—w((·qçåOó£Âq=\x0f7a²P†LÀ9ŸÇ\x1aŒ\v6¢ \x1aBË\x1e}Wö¦²Ð,e}4\x1e\x10ÞQg)woŠ‘Ìh\x06\0±o¢\x17²d…0Õ6ãF–çÞJ¥&Š\x04A6W\x05Å]òÈü¼3‚X¥\x1f«\x12rKìÑaÊ-Ÿ´/¦÷
\x02G7dlg´1À bÕ§¦²úúäW„^ŸÀc\x16†åÛ”nË ^[Ãࠝ:nÁ\0\x01T\r@íÜ]jnˆŸç4²çZãîœ\x12‰R[«\x17_Ø`þ›é®\x17EiÀ7!†ª›Lî\x1e\x16£ˆI\x04\x18\x11\x02\0	\x05\x02FgËN\x02^[\f\0
	\x10\x13¶õ\x1eÍÞC\rÁì\0 Ðr€-\rbEº•QªW	ìñá\r¤„\0œ
Ï¿.Ñ<-¿a\v휾½î\x1fš|Ø\x02

Re: t7004-tag.sh fails (old gpg?)

[Sven Verdoolaege]

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On Sun, Jul 01, 2007 at 07:30:09PM +0100, Johannes Schindelin wrote:
> Aargh! I am a complete moron. Attached also the private key now.

Ok... some progress...

* expecting success: git-tag -v signed-tag
object 86e17e4ed4cddf9a4f960da789f8378f6ea1ff2b
type commit
tag signed-tag
tagger C O Mitter <committer@example.com> Thu Apr 7 15:13:13 2005 -0700

A signed tag message
gpg: Warning: using insecure memory!
gpg: Signature made Sun Jul  1 19:08:37 2007 UTC using DSA key ID CDDE430D
gpg: Good signature from "C O Mitter <committer@example.com>"
gpg: NOTE: secret key CDDE430D is NOT protected.
gpg: /home/skimo/src/git/t/trash/gpghome/trustdb.gpg: invalid file version 3
gpg: fatal: /home/skimo/src/git/t/trash/gpghome/trustdb.gpg: invalid trustdb
secmem usage: 1408/1408 bytes in 2/2 blocks of pool 1408/16384
* FAIL 50: verifying a signed tag should succeed
        git-tag -v signed-tag

skimo

[-- Attachment #2: secring.gpg --]
[-- Type: application/octet-stream, Size: 1229 bytes --]