git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org, gitster@pobox.com,
	Frank Lichtenheld <frank@lichtenheld.de>,
	j.sixt@eudaptics.com
Subject: Re: [PATCH] filter-branch documentation: some more touch-ups.
Date: Wed, 4 Jul 2007 11:58:18 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707041155110.4071@racer.site> (raw)
In-Reply-To: <1183534367401-git-send-email-johannes.sixt@telecom.at>

Hi,

On Wed, 4 Jul 2007, Johannes Sixt wrote:

> - The map function used to fail, but no longer does (since 3520e1e8687.)
> - Fix the "edge-graft" example.
> - Show the same using .git/info/grafts.
> 
> Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
> ---
> 
> I think that "edge-graft" makes more sense than "etch-graft".
> Native speakers, please?

I looked at dict.leo.org, and it does not know either version. Maybe it is 
just "graft"?

Except for that,

Acked-by: Johannes E. Schindelin <johannes.schindelin@gmx.de>

> I tried the example, and its quoting was incorrect. The reason is that
> the shell removes the single quotes even if they are in the middle of
> a word; so they didn't end up in the eval'd script and made sed barf.

Thanks for sanity checking. It looked so obviously correct to me that I 
did not bother checking, but your are correct, they were broken. 
Unfortunately, I even would have missed it writing a test case, because 
that need an extra level of quoting!

Ciao,
Dscho

  reply	other threads:[~2007-07-04 10:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-03 16:47 [PATCH] Document git-filter-branch Johannes Schindelin
2007-07-03 22:05 ` Frank Lichtenheld
2007-07-03 23:17   ` Johannes Schindelin
2007-07-04 11:29     ` Frank Lichtenheld
2007-07-04 14:50       ` [PATCH] filter-branch: a few more touch ups to the man page Johannes Schindelin
2007-07-04 15:06         ` Frank Lichtenheld
2007-07-11 16:53     ` [PATCH] Document git-filter-branch Jakub Narebski
2007-07-11 17:03       ` Johannes Schindelin
2007-07-03 23:41   ` Johannes Schindelin
2007-07-04  7:32   ` [PATCH] filter-branch documentation: some more touch-ups Johannes Sixt
2007-07-04 10:58     ` Johannes Schindelin [this message]
2007-07-04 16:56       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707041155110.4071@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=frank@lichtenheld.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@eudaptics.com \
    --cc=johannes.sixt@telecom.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).