From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] diff: add custom regular expressions for function names
Date: Wed, 4 Jul 2007 19:45:26 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707041944520.4071@racer.site> (raw)
In-Reply-To: <alpine.LFD.0.98.0707041140230.9434@woody.linux-foundation.org>
Hi,
On Wed, 4 Jul 2007, Linus Torvalds wrote:
> On Wed, 4 Jul 2007, Johannes Schindelin wrote:
> >
> > This patch introduces a config variable diff.functionNameRegexp
> > which replaces the default heuristics. If the pattern contains
> > a group, the match of this group is used for the hunk header
> > instead of the whole match.
>
> Umm. Shouldn't it be a path-name based attribute instead?
>From my original mail:
Yes, I know. .gitattributes integration would be nice. But for now
I am done with it. I invested way too much time into this.
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-04 18:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-04 18:06 [PATCH 2/2] diff: add custom regular expressions for function names Johannes Schindelin
2007-07-04 18:41 ` Linus Torvalds
2007-07-04 18:45 ` Johannes Schindelin [this message]
2007-07-04 20:44 ` Junio C Hamano
2007-07-04 21:20 ` Johannes Schindelin
2007-07-05 5:00 ` Junio C Hamano
2007-07-05 5:02 ` [PATCH 1/2] Future-proof source for changes in xdemitconf_t Junio C Hamano
2007-07-05 11:01 ` Johannes Schindelin
2007-07-05 5:02 ` [PATCH 2/2] WIP per-path attribute based hunk header selection Junio C Hamano
2007-07-05 11:25 ` Johannes Schindelin
2007-07-05 16:43 ` Junio C Hamano
2007-07-06 8:37 ` [PATCH 1/3] Introduce diff_filespec_is_binary() Junio C Hamano
2007-07-06 12:20 ` Johannes Schindelin
2007-07-06 8:39 ` [PATCH] Per-path attribute based hunk header selection Junio C Hamano
2007-07-06 12:38 ` Johannes Schindelin
2007-07-06 17:59 ` Linus Torvalds
2007-07-07 2:00 ` Junio C Hamano
2007-07-07 10:08 ` しらいしななこ
2007-07-07 10:22 ` Junio C Hamano
2007-07-07 12:17 ` Johannes Schindelin
2007-07-07 20:36 ` Junio C Hamano
2007-07-08 7:23 ` Junio C Hamano
2007-07-08 11:58 ` Johannes Schindelin
2007-07-09 3:22 ` Nicolas Pitre
2007-07-09 5:05 ` Junio C Hamano
2007-07-09 11:40 ` Johannes Schindelin
2007-07-07 10:12 ` [PATCH] Fix configuration syntax to specify customized hunk header patterns Junio C Hamano
2007-07-05 8:24 ` [PATCH 2/2] diff: add custom regular expressions for function names Florian Weimer
2007-07-05 11:44 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707041944520.4071@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).