git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: "Uwe Kleine-König" <ukleinek@informatik.uni-freiburg.de>,
	torvalds@linux-foundation.org, gitster@pobox.com,
	mkraai@beckman.com, madcoder@debian.org, git@vger.kernel.org
Subject: Re: [PATCH] Prefer $EMAIL over auto-generated user@hostname.
Date: Fri, 6 Jul 2007 16:32:32 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707061631560.4093@racer.site> (raw)
In-Reply-To: <468E5E31.8040504@nrlssc.navy.mil>

Hi,

On Fri, 6 Jul 2007, Brandon Casey wrote:

> Uwe Kleine-K?nig wrote:
> > Hello Brandon,
> > 
> > Brandon Casey wrote:
> >>  	struct passwd *pw = NULL;
> >> +        char *email;
> > Indention error. Otherwise it looks good (just from reading the patch).
> 
> huh. It doesn't look like that in my mail reader.
> I have
>         struct passwd...
> +        char *email;
> 
> and the patch applied cleanly when I saved the email and applied it
> using git-am
> 
>   cat git_email.patch | git-am

Yes, it applies cleanly. But it has 8 spaces before "char *email", not a 
tab (otherwise it would be lined up with "struct passwd").

Hth,
Dscho

  reply	other threads:[~2007-07-06 15:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-06 15:03 [PATCH] Prefer $EMAIL over auto-generated user@hostname Brandon Casey
2007-07-06 15:11 ` Uwe Kleine-König
2007-07-06 15:22   ` Brandon Casey
2007-07-06 15:32     ` Johannes Schindelin [this message]
2007-07-06 15:51       ` Brandon Casey
2007-07-06 15:59         ` Alex Riesen
2007-07-06 15:59           ` Vincent Hanquez
2007-07-06 16:22             ` Alex Riesen
2007-07-06 16:23               ` Alex Riesen
  -- strict thread matches above, loose matches on Subject: below --
2007-07-06 16:14 Brandon Casey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707061631560.4093@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    --cc=mkraai@beckman.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ukleinek@informatik.uni-freiburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).