From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Deprecate git-cherry
Date: Fri, 6 Jul 2007 22:21:42 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707062212280.4093@racer.site> (raw)
In-Reply-To: <7vmyy9dzrr.fsf@assigned-by-dhcp.cox.net>
Hi,
On Fri, 6 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > A cleaner alternative was introduced in v1.5.2~185^2~1, which not only
> > allows you to list the commits, but to inspect them, too:
> >
> > git log --cherry-pick <upstream>...[<head>]
> >
> > There is a functional difference, though: git cherry shows both
> > directions, <upstream>...<head> and <head>...<upstream>, and prefixes
> > the commits with '+' and '-', respectively.
> >
> > 'git rev-list --cherry-pick <upstream>...[<head>]' only shows one
> > direction, and does not prefix the commits.
>
> Eh, --left-right anybody?
>
> git-cherry is used by people's scripts, and I do not think
> deprecating is an option at least in the short term.
Okay, I should have been more precise.
Maybe there are some interesting scripts that use "git cherry". I'd like
to see them (which does not mean that I vote for git-cherry removal).
Personally, I use "git rev-list --cherry-pick", because it spares me one
call to sed.
However, I do not think that there is much value in advertising it any
more. There is much more value in "git log --cherry-pick", since you can
get the commit messages and the patches by just adding one more flag (and
absent any path parameter, that can be even _at the end_ of the command
line, making it even more convenient).
So what I meat was: advertise "git log --cherry-pick" instead of "git
cherry", since it is vastly more useful.
There is one real consequence on my common usage, though: It annoys me
whenever I want to cherry pick a commit, which happens quite often, that
the bash completion completes on this (for me) useless command. I would
like to see that gone (but only after a grace period, evidently).
Ciao,
Dscho
prev parent reply other threads:[~2007-07-06 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 16:29 [PATCH] Deprecate git-cherry Johannes Schindelin
2007-07-06 20:48 ` Junio C Hamano
2007-07-06 21:21 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707062212280.4093@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).