From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: skimo@liacs.nl
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] revision: allow selection of commits that do not match a pattern
Date: Sat, 7 Jul 2007 17:27:23 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707071724410.4093@racer.site> (raw)
In-Reply-To: <20070707153001.GA10408MdfPADPa@greensroom.kotnet.org>
Hi,
On Sat, 7 Jul 2007, Sven Verdoolaege wrote:
> We do this by maintaining two lists of patterns, one for
> those that should match and one for those that should not match.
I suspect that with this patch,
git rev-list --not --grep bugfix HEAD
does not work as expected. Why? Because the --not is heeded when
interpreting "HEAD". And that is confusing, because you use --not for two
completely unrelated things.
Why not make "git rev-list --grep '!bugfix' HEAD" work?
Yes, you would have to have a special exception that the prefix "!!"
actually matches an exclamation mark, but I'd be willing to live with
that.
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-07 16:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 15:30 [PATCH] revision: allow selection of commits that do not match a pattern Sven Verdoolaege
2007-07-07 16:27 ` Johannes Schindelin [this message]
2007-07-07 16:52 ` Sven Verdoolaege
2007-07-07 17:33 ` Johannes Schindelin
2007-07-07 18:42 ` Sven Verdoolaege
2007-07-07 19:35 ` Johannes Schindelin
2007-07-07 20:22 ` Sven Verdoolaege
2007-07-08 10:57 ` [PATCH v3] " Sven Verdoolaege
2007-07-08 14:22 ` Johannes Schindelin
2007-07-08 14:57 ` Sven Verdoolaege
2007-07-11 17:42 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707071724410.4093@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=skimo@liacs.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).