From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Barkalow Subject: Re: [PATCH 1/2] Add for_each_remote() function, and extend remote_find_tracking() Date: Mon, 9 Jul 2007 23:55:53 -0400 (EDT) Message-ID: References: <7vhcof2rur.fsf@assigned-by-dhcp.cox.net> <7vzm2620wp.fsf@assigned-by-dhcp.cox.net> <46919692.5020708@gnu.org> <7vhcoexqeh.fsf@assigned-by-dhcp.cox.net> <7v4pkduw2f.fsf@assigned-by-dhcp.cox.net> <7vzm25tex6.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Junio C Hamano , Paolo Bonzini , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Jul 10 05:56:22 2007 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1I86pn-0007dR-Lq for gcvg-git@gmane.org; Tue, 10 Jul 2007 05:56:19 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756900AbXGJDz4 (ORCPT ); Mon, 9 Jul 2007 23:55:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755063AbXGJDz4 (ORCPT ); Mon, 9 Jul 2007 23:55:56 -0400 Received: from iabervon.org ([66.92.72.58]:2610 "EHLO iabervon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754918AbXGJDzz (ORCPT ); Mon, 9 Jul 2007 23:55:55 -0400 Received: (qmail 19871 invoked by uid 1000); 10 Jul 2007 03:55:53 -0000 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 10 Jul 2007 03:55:53 -0000 In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: On Tue, 10 Jul 2007, Johannes Schindelin wrote: > The function for_each_remote() does exactly what the name suggests. > > The function remote_find_tracking() was extended to be able to search > remote refs for a given local ref. You have to set the parameter > "reverse" to true for that behavior. I think I'd like this better if reverse meant that it looked at refspec->dst and set refspec->src, rather than returning the refspec reversed; the current version sets the refspec so that it's effectively something from the list, which makes it easier to understand. Maybe make it so the user calls it with at most one of src and dst NULL, and it returns with neither NULL or returns -1 if it can't find anything? -Daniel *This .sig left intentionally blank*