From: Daniel Barkalow <barkalow@iabervon.org>
To: git@vger.kernel.org
Subject: [RFC] series headers
Date: Tue, 10 Jul 2007 02:14:00 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0707100126250.6977@iabervon.org> (raw)
I'd like to be able to get format-patch to produce a [PATCH 0/N] message,
with a message that's actually in my repository, plus various goodies
generated either from diffing the ends of the series or by running through
the log an extra time to pick up summary information.
The second best idea I have for this currently is to have a commit at the
end of the series which specifies which has the same tree as its parent
and has a message with a line "Since <sha1 of the first commit of the
series>" and has the text. This goes at the end of the series, because it
describes the state with all of the changes made, which is only a good
description of a commit at the end of the series, not a commit at the
start of the series. Making it [PATCH 0/N] is just because it belongs
first in presentation, regardless of whether the other commits are
presented with recent commits first or last.
The better idea I just had was to have format-patch notice if the "until"
side is a tag object instead of a commit, and generate a [0/N] with the
tag message.
As far as implementing this... would it be sane to make struct
rev_info.commit_format a callback, so that the code to generate an email
message can be somewhere that's easy to use to generate an email that
isn't for a commit in the log? I don't *think* git's quite fast enough for
the indirect jump to a callback instead of an if tree for an enum will
actually hurt us.
-Daniel
*This .sig left intentionally blank*
next reply other threads:[~2007-07-10 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-10 6:14 Daniel Barkalow [this message]
2007-07-10 6:57 ` [RFC] series headers Junio C Hamano
2007-07-10 13:24 ` Theodore Tso
2007-07-10 13:56 ` Johannes Schindelin
2007-07-10 14:48 ` Theodore Tso
2007-07-10 15:23 ` Johannes Schindelin
2007-07-10 13:26 ` [PATCH] Teach the --cover-letter option to format-patch Johannes Schindelin
2007-07-10 17:20 ` Daniel Barkalow
2007-07-10 17:20 ` Johannes Schindelin
2007-07-24 20:12 ` Peter Oberndorfer
2007-07-24 20:19 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707100126250.6977@iabervon.org \
--to=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).