From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: David Kastrup <dak@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: Installation failure caused by CDPATH environment variable
Date: Thu, 12 Jul 2007 12:37:18 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707121234390.4516@racer.site> (raw)
In-Reply-To: <86sl7u12m3.fsf@lola.quinscape.zz>
Hi,
[please Cc' me if you already quote me and answer directly to my message]
On Thu, 12 Jul 2007, David Kastrup wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > On Wed, 11 Jul 2007, Wincent Colaiuta wrote:
> >
> >> [describes the typical CDPATH problem]
> >
> > You exported CDPATH. You're guaranteed to run into problems with
> > that. I doubt that your patch catches all problems in git, and even
> > if we tried to avoid breakage, you can only do so much about that.
> >
> > It is _wrong_ to export CDPATH.
>
> But it is not our job to educate people about that. So I'd just add
> something like
>
> [ "X" = "X$CDPATH" ] || unset CDPATH # ignore braindamaged exports
>
> to the top of possibly affected scripts and be done.
We have that already, and we're not done.
> A one-liner that makes this somebody else's problem (if at all) is worth
> its weight in gold.
That is right. And a one-liner that pretends to be a solve-all, but is
not, is worth its weight in lead.
I bet that in ten years we find yet another instance where exporting
CDPATH, which you should not have done in the first place, breaks Git.
Ciao,
Dscho "who chants wrong, wrong, wrong"
next prev parent reply other threads:[~2007-07-12 11:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-11 16:59 Installation failure caused by CDPATH environment variable Wincent Colaiuta
2007-07-11 17:09 ` Johannes Schindelin
2007-07-12 7:51 ` David Kastrup
2007-07-12 8:34 ` Junio C Hamano
2007-07-12 10:24 ` Wincent Colaiuta
2007-07-12 11:52 ` Johannes Schindelin
2007-07-12 11:37 ` Johannes Schindelin [this message]
2007-07-11 21:26 ` Junio C Hamano
2007-07-17 11:40 ` Uwe Kleine-König
2007-07-17 18:37 ` Junio C Hamano
2007-07-17 19:07 ` Wincent Colaiuta
2007-07-17 20:19 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707121234390.4516@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=dak@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).