git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Christian Stimming <stimming@tuhh.de>
Cc: git@vger.kernel.org, Shawn Pearce <spearce@spearce.org>
Subject: Re: [PATCH] Internationalization of git-gui
Date: Thu, 19 Jul 2007 13:25:18 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707191323510.14781@racer.site> (raw)
In-Reply-To: <20070719125657.8utk85ynuow4ow48@webmail.tu-harburg.de>

Hi,

On Thu, 19 Jul 2007, Christian Stimming wrote:

> Does this implementation look okay?

This is valuable work, but unfortunately, it does not follow the 
recommendation in Documentation/SubmittingPatches at all.

For starters, please send the patches inlined, one per mail.  And you 
might want to Cc the maintainer of git-gui (Shawn Pearce), too...

Ciao,
Dscho

  reply	other threads:[~2007-07-19 12:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-19 10:56 [PATCH] Internationalization of git-gui Christian Stimming
2007-07-19 12:25 ` Johannes Schindelin [this message]
2007-07-20  4:55   ` Shawn O. Pearce
2007-07-20 17:32     ` Paolo Ciarrocchi
2007-07-20 18:10       ` Junio C Hamano
2007-07-20 18:38         ` Johannes Schindelin
2007-07-20 18:47           ` Paolo Ciarrocchi
2007-07-20 19:06             ` Johannes Schindelin
2007-07-20 19:02         ` Sam Ravnborg
2007-07-20 19:16         ` Xudong Guan
2007-07-21  8:12         ` しらいしななこ
2007-07-21  8:22           ` Junio C Hamano
2007-07-21 13:21             ` Johannes Schindelin
2007-07-21 18:57             ` Paolo Ciarrocchi
2007-07-21 21:25               ` Johannes Schindelin
2007-07-21 22:57                 ` Junio C Hamano
2007-07-22  1:12                   ` Johannes Schindelin
  -- strict thread matches above, loose matches on Subject: below --
2007-07-19 17:33 Brett Schwarz
2007-07-20  5:04 ` Shawn O. Pearce
2007-07-20  8:56   ` Christian Stimming
2007-07-21  2:17     ` Shawn O. Pearce
2007-07-21  7:50       ` Christian Stimming
2007-07-21  8:03         ` Shawn O. Pearce
2007-07-20  9:03 ` Christian Stimming
2007-07-20 18:15 Brett Schwarz
2007-07-20 18:34 Brett Schwarz
2007-07-20 21:40 ` Christian Stimming
2007-07-21 16:29 Brett Schwarz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707191323510.14781@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    --cc=stimming@tuhh.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).