* [PATCH 2/2] builtin-tag: fix uninitialized variables
@ 2007-07-20 12:07 Johannes Schindelin
0 siblings, 0 replies; only message in thread
From: Johannes Schindelin @ 2007-07-20 12:07 UTC (permalink / raw)
To: git, gitster, jasampler
The function launch_editor() expects the variables 'buffer' and 'size'
to be initialized, either to an existing buffer, or to NULL and 0.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
This is only called 2/2, because I found this error by testing
1/2...
builtin-tag.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin-tag.c b/builtin-tag.c
index cf36def..81d37ce 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -253,9 +253,9 @@ static void create_tag(const unsigned char *object, const char *tag,
char *message, int sign, unsigned char *result)
{
enum object_type type;
- char header_buf[1024], *buffer;
+ char header_buf[1024], *buffer = NULL;
int header_len, max_size;
- unsigned long size;
+ unsigned long size = 0;
type = sha1_object_info(object, NULL);
if (type <= 0)
--
1.5.3.rc1.16.g9d6f-dirty
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-07-20 12:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-20 12:07 [PATCH 2/2] builtin-tag: fix uninitialized variables Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).