From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Chris Larson <clarson@kergoth.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-submodule fixes for call to git config --get-regexp
Date: Fri, 20 Jul 2007 19:36:43 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707201933360.14781@racer.site> (raw)
In-Reply-To: <7vsl7jvthk.fsf@assigned-by-dhcp.cox.net>
Hi,
On Fri, 20 Jul 2007, Junio C Hamano wrote:
> "Chris Larson" <clarson@kergoth.com> writes:
>
> > + name=$(GIT_CONFIG=.gitmodules git config --get-regexp
> > '^submodule\..*\.path$' "^$path$" |
> > sed -nre 's/^submodule\.(.+)\.path .+$/\1/p')
I wonder why it is a regular expression to begin with, since we seem to
prefer shell patterns on paths.
However, _if_ we already go with regexps, why not just put it into the
"sed" call, which is _already_ there, and leave "git config" alone? IOW
call
git config --get-regexp '^submodule\..*\.path$' |
sed -nre 's/^submodule\.(.*$path.*)\.path .+$\1/p'
Hmm?
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-20 18:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-28 20:51 [PATCH] Let .git/config specify the url for submodules Lars Hjemli
2007-05-31 0:17 ` Lars Hjemli
2007-05-31 23:43 ` Junio C Hamano
2007-06-01 8:08 ` Josef Weidendorfer
2007-06-01 9:17 ` Lars Hjemli
2007-06-01 8:57 ` Sven Verdoolaege
2007-06-01 9:25 ` Lars Hjemli
2007-06-01 9:35 ` Sven Verdoolaege
2007-06-01 14:45 ` Lars Hjemli
2007-06-01 14:51 ` Sven Verdoolaege
2007-06-01 15:56 ` Lars Hjemli
2007-06-01 16:29 ` Linus Torvalds
2007-06-01 19:55 ` Junio C Hamano
2007-06-02 7:13 ` Lars Hjemli
2007-06-02 7:44 ` Sven Verdoolaege
2007-06-02 8:39 ` Lars Hjemli
2007-06-02 9:15 ` Junio C Hamano
2007-06-02 9:53 ` Lars Hjemli
2007-06-02 10:12 ` Junio C Hamano
2007-06-02 10:38 ` Lars Hjemli
2007-07-20 17:23 ` [PATCH] git-submodule fixes for call to git config --get-regexp Chris Larson
2007-07-20 18:07 ` Junio C Hamano
2007-07-20 18:36 ` Johannes Schindelin [this message]
2007-07-25 0:09 ` submodule init problem Ricky Nite
2007-07-25 0:30 ` Ricky Nite
2007-07-25 1:49 ` Junio C Hamano
2007-07-25 8:15 ` Sven Verdoolaege
2007-07-25 20:25 ` Lars Hjemli
2007-07-25 20:31 ` Johannes Schindelin
2007-07-25 20:40 ` Lars Hjemli
2007-07-25 20:50 ` Johannes Schindelin
2007-07-25 22:20 ` Junio C Hamano
2007-07-25 23:43 ` Ricky Nite
2007-07-25 23:49 ` Junio C Hamano
2007-06-02 7:49 ` [PATCH] Let .git/config specify the url for submodules Sven Verdoolaege
2007-06-02 16:34 ` Linus Torvalds
2007-06-02 17:35 ` Sven Verdoolaege
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707201933360.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=clarson@kergoth.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).