git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Add --log-size to git log to print message size
Date: Fri, 20 Jul 2007 19:41:08 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707201939170.14781@racer.site> (raw)
In-Reply-To: <e5bfff550707201115v2531434erd9e10a2b816a59bf@mail.gmail.com>

Hi,

On Fri, 20 Jul 2007, Marco Costalba wrote:

> This is take 3 of this patch. In this case has been clearly added that 
> diff content size is not included.

Two concerns and a half:

- if you do not include the diff content size, don't you need to parse the 
  output anyway?

- what do you do if the underlying Git does not support --log-size? Exit?

- Would it not be much quicker to read the rev-list, and read messages 
  only on demand?

Ciao,
Dscho

  reply	other threads:[~2007-07-20 18:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-20 18:15 [PATCH] Add --log-size to git log to print message size Marco Costalba
2007-07-20 18:41 ` Johannes Schindelin [this message]
2007-07-20 20:49   ` Marco Costalba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707201939170.14781@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mcostalba@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).