From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fsck --lost-found: write blob's contents, not their SHA-1
Date: Sun, 22 Jul 2007 22:52:28 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707222246220.14781@racer.site> (raw)
In-Reply-To: <7vodi4qfnx.fsf@assigned-by-dhcp.cox.net>
Hi,
On Sun, 22 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > When looking for a lost blob, it is much nicer to be able to grep
> > through .git/lost-found/other/* than to write an inefficient loop
> > over the file names. So write the contents of the dangling blobs,
> > not their object names.
>
> I think this is an idea to solve a good problem, but if we go
> this route, the need for us to worry about expiring lost-found
> entries would become more urgent, I suspect.
Why? AFAICT lost+found/ has to be cleaned by people. So if you look for
something, you say "git fsck --lost-found", and once you found it, it's
time for "rm -rf .git/lost-found".
> And when you think about expiring lost-found entries, another
> possible solution emerges. If we teach git-prune to remove the
> corresponding entry from lost-found/other when it removes a
> loose blob from the object store, then we can easily and safely
> do this instead:
>
> $ cat .git/lost-found/other/* |
> xargs -r git grep 'the word to look for'
Well, it is not only for grepping. In my case, I could get away by this:
$ ls -lrt $(grep -l filter_subdir .git/lost-found/other/* |
sed "s/^.*other\/\(..\)/.git\/objects\/\1\//")
IOW I found the loose dangling objects which matched a keyword, and sorted
them by time.
In other cases, though, I wanted to see the size.
But what the whole thing boils down to: After finding dangling objects,
you are much more likely using git tools on non-blobs than on blobs, and
vice versa.
Ciao,
Dscho
P.S.: I fully forgot to mention that happily, I did "git add -u" sometime
before "git reset --hard", otherwise I would have been lost.
next prev parent reply other threads:[~2007-07-22 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 20:20 [PATCH] fsck --lost-found: write blob's contents, not their SHA-1 Johannes Schindelin
2007-07-22 21:42 ` Junio C Hamano
2007-07-22 21:52 ` Johannes Schindelin [this message]
2007-07-22 23:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707222246220.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).