From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Steven Grimm <koreth@midwinter.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Teach git-commit about commit message templates.
Date: Mon, 23 Jul 2007 11:04:04 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707231059490.14781@racer.site> (raw)
In-Reply-To: <20070723041741.GA22461@midwinter.com>
Hi,
On Sun, 22 Jul 2007, Steven Grimm wrote:
> @@ -572,10 +591,35 @@ else
> fi |
> git stripspace >"$GIT_DIR"/COMMIT_MSG
>
> -if cnt=`grep -v -i '^Signed-off-by' "$GIT_DIR"/COMMIT_MSG |
> - git stripspace |
> - wc -l` &&
> - test 0 -lt $cnt
> +# Test whether the commit message has any content we didn't supply.
> +have_commitmsg=
> +grep -v -i '^Signed-off-by' "$GIT_DIR"/COMMIT_MSG |
> + git stripspace > "$GIT_DIR"/COMMIT_BAREMSG
Up until here, I was with you. But this feels very wrong.
Why not compare COMMIT_MSG to the templatefile, if there is one? I.e.
test ! -z "$templatefile" && cmp "$GIT_DIR"/COMMIT_MSG "$templatefile" &&
die "Unchanged message; will not commit"
Hmm?
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-23 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 4:17 [PATCH] Teach git-commit about commit message templates Steven Grimm
2007-07-23 10:04 ` Johannes Schindelin [this message]
2007-07-23 10:23 ` Steven Grimm
2007-07-23 10:40 ` Johannes Schindelin
2007-07-23 10:56 ` Steven Grimm
2007-07-23 11:58 ` Johannes Schindelin
2007-07-23 17:12 ` Junio C Hamano
2007-07-24 12:01 ` Steven Grimm
2007-07-24 21:43 ` Junio C Hamano
2007-07-25 6:42 ` Steven Grimm
2007-07-25 7:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707231059490.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=koreth@midwinter.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).