git-send-email and pine alias format

git-send-email and pine alias format

[Kumar Gala]

I was wondering why we don't parse the pine alias format according to the
following spec:

http://www.washington.edu/pine/tech-notes/low-level.html

I'd expect omething like, to get the address field.

@@ -225,7 +238,7 @@ my %parse_alias = (
                        $aliases{$1} = [ split(/\s+/, $2) ];
                }}},
        pine => sub { my $fh = shift; while (<$fh>) {
-               if (/^(\S+)\t.*\t(.*)$/) {
+               if (/^(\S+)\s+(.*)$/) {
                        $aliases{$1} = [ split(/\s*,\s*/, $2) ];
                }}},
        gnus => sub { my $fh = shift; while (<$fh>) {

- k

Re: git-send-email and pine alias format

[Junio C Hamano]

Kumar Gala <galak@kernel.crashing.org> writes:

> I was wondering why we don't parse the pine alias format according to the
> following spec:
>
> http://www.washington.edu/pine/tech-notes/low-level.html
>
> I'd expect something like, to get the address field.

My guess is simply because we got a "works-for-us" regexp by
observing the program's behaviour, done by real Pine users.  On
top of that, probably nobody knew and/or bothered to check if
there is such "official spec" available.

Could you send a signed and testable patch to the list so other
Pine users can try it out please?  After seeing a few Ack's on
the list, I'd like to apply it and preferably do so before 1.5.3
final.

Re: git-send-email and pine alias format

[Kumar Gala]

On Mon, 23 Jul 2007, Junio C Hamano wrote:

> Kumar Gala <galak@kernel.crashing.org> writes:
>
> > I was wondering why we don't parse the pine alias format according to the
> > following spec:
> >
> > http://www.washington.edu/pine/tech-notes/low-level.html
> >
> > I'd expect something like, to get the address field.
>
> My guess is simply because we got a "works-for-us" regexp by
> observing the program's behaviour, done by real Pine users.  On
> top of that, probably nobody knew and/or bothered to check if
> there is such "official spec" available.
>
> Could you send a signed and testable patch to the list so other
> Pine users can try it out please?  After seeing a few Ack's on
> the list, I'd like to apply it and preferably do so before 1.5.3
> final.

Ok, done.

- k