git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Sean <seanlkml@sympatico.ca>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, git@vger.kernel.org
Subject: Re: rfe: bisecting with a tristate
Date: Tue, 24 Jul 2007 14:52:40 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707241447200.14781@racer.site> (raw)
In-Reply-To: <20070724094017.d14688e5.seanlkml@sympatico.ca>

Hi,

On Tue, 24 Jul 2007, Sean wrote:

> > git bisect start
> > git bisect bad v2.6.23-rc1
> > # bad: [f695baf2df9e0413d3521661070103711545207a] Linux 2.6.23-rc1
> > git bisect good v2.6.22
> > # good: [098fd16f00005f665d3baa7e682d8cb3d7c0fe6f] Linux 2.6.22
> > 
> > Then 1f1c2881f673671539b25686df463518d69c4649 will be the next commit 
> > git bisect hands out. Now let's assume this commit would not compile. 
> > What would the user do? git-bisect good or git-bisect bad?
> 
> Check out the section "Avoiding to test a commit" in the git-bisect
> man page; it addresses this issue.  Basically you just use git-reset
> to pick a different nearby commit to compile, and then continue with
> git bisect good/bad.

But a "git bisect dunno" would be handy.

However, it is a bit involved, since git-bisect.sh assumes that there is 
only one bad commit, and with that, the outcome would be possibly a commit 
range.

Two parts to it I see:

- builtin-rev-list.c:find_bisection() has to be told to ignore the dunno 
  commits when counting, in addition to uninteresting ones (but not stop 
  traversal). The easiest way I could see would be to add another option 
  to specify the dunno commits, and set a special flag on these.

- git-bisect.sh has to lose the assumption that there is only one bad 
  commit.  Instead, it has to traverse the parent(s) of "the" bad commit, 
  until it finds either no parents, or a known good one.  So maybe 
  something like

	echo $(git rev-list --boundary $bad --not $good |
		sed -n "s/^-/^/p") $bad

  would be enough.

Hth,
Dscho

  reply	other threads:[~2007-07-24 13:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 13:21 rfe: bisecting with a tristate Jan Engelhardt
2007-07-24 13:40 ` Sean
2007-07-24 13:52   ` Johannes Schindelin [this message]
2007-07-24 17:07     ` Robin Rosenberg
2007-07-24 17:21       ` Johannes Schindelin
2007-07-24 21:39         ` Robin Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707241447200.14781@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jengelh@computergmbh.de \
    --cc=seanlkml@sympatico.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).