git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: Sean <seanlkml@sympatico.ca>,
	Jan Engelhardt <jengelh@computergmbh.de>,
	git@vger.kernel.org
Subject: Re: rfe: bisecting with a tristate
Date: Tue, 24 Jul 2007 18:21:33 +0100 (BST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0707241818450.14781@racer.site> (raw)
In-Reply-To: <200707241907.57857.robin.rosenberg.lists@dewire.com>

Hi,

On Tue, 24 Jul 2007, Robin Rosenberg wrote:

> tisdag 24 juli 2007 skrev Johannes Schindelin:
> 
> > On Tue, 24 Jul 2007, Sean wrote:
> > 
> > > > git bisect start
> > > > git bisect bad v2.6.23-rc1
> > > > # bad: [f695baf2df9e0413d3521661070103711545207a] Linux 2.6.23-rc1
> > > > git bisect good v2.6.22
> > > > # good: [098fd16f00005f665d3baa7e682d8cb3d7c0fe6f] Linux 2.6.22
> > > > 
> > > > Then 1f1c2881f673671539b25686df463518d69c4649 will be the next commit 
> > > > git bisect hands out. Now let's assume this commit would not compile. 
> > > > What would the user do? git-bisect good or git-bisect bad?
> > > 
> > > Check out the section "Avoiding to test a commit" in the git-bisect
> > > man page; it addresses this issue.  Basically you just use git-reset
> > > to pick a different nearby commit to compile, and then continue with
> > > git bisect good/bad.
> > 
> > But a "git bisect dunno" would be handy.
> 
> Why? Not doing anything is enough, just select a new commit. Going back 
> can be done by git reset, but forward (towards original HEAD) requires 
> more thinking so a git bisect forward [n] would help there.

And why exactly do you want to make it hard on the user?

Imagine this history:

	A - B - broken - bad - C

Now you bisect.  It goes to "broken".  You compile.  Darn, does not 
compile.  Why not have a "git bisect dunno", which considers only the 
_rest_ of the commits for the next bisection point?  When it finally found 
the "bad" one, it has to say it broke somewhere between "B..bad".

Now that would be user friendly, wouldn't it?

Ciao,
Dscho

  reply	other threads:[~2007-07-24 17:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-24 13:21 rfe: bisecting with a tristate Jan Engelhardt
2007-07-24 13:40 ` Sean
2007-07-24 13:52   ` Johannes Schindelin
2007-07-24 17:07     ` Robin Rosenberg
2007-07-24 17:21       ` Johannes Schindelin [this message]
2007-07-24 21:39         ` Robin Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0707241818450.14781@racer.site \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jengelh@computergmbh.de \
    --cc=robin.rosenberg.lists@dewire.com \
    --cc=seanlkml@sympatico.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).