From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
Date: Thu, 26 Jul 2007 04:31:54 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0707260431240.14781@racer.site> (raw)
In-Reply-To: <7v7ioocatt.fsf@assigned-by-dhcp.cox.net>
Hi,
On Wed, 25 Jul 2007, Junio C Hamano wrote:
> From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
> Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
> Date: Wed, 25 Jul 2007 12:49:53 -0400
> Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
>
> Changed git_commit_set_multivar() to use the routines provided by
> lockfile.c to reduce code duplication and ensure consistent behavior.
>
> Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
>
> Dscho, I think this is worth doing regardless of that "symlinked
> config" issue. I haven't followed the code closely enough,
> though.
>
> What do you think?
I think that I will review it tomorrow; this darned work-tree stuff took
way longer than expected.
Ciao,
Dscho
next prev parent reply other threads:[~2007-07-26 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 23:39 [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Junio C Hamano
2007-07-26 3:31 ` Johannes Schindelin [this message]
[not found] ` <f158199e0707261040u70ee31d3le2eaf21ab1302909@mail.gmail.com>
2007-07-26 18:26 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0707260431240.14781@racer.site \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).