* [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
@ 2007-07-25 23:39 Junio C Hamano
2007-07-26 3:31 ` Johannes Schindelin
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2007-07-25 23:39 UTC (permalink / raw)
To: Johannes Schindelin; +Cc: git
From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
Date: Wed, 25 Jul 2007 12:49:53 -0400
Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
Changed git_commit_set_multivar() to use the routines provided by
lockfile.c to reduce code duplication and ensure consistent behavior.
Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
Dscho, I think this is worth doing regardless of that "symlinked
config" issue. I haven't followed the code closely enough,
though.
What do you think?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
2007-07-25 23:39 [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Junio C Hamano
@ 2007-07-26 3:31 ` Johannes Schindelin
[not found] ` <f158199e0707261040u70ee31d3le2eaf21ab1302909@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Schindelin @ 2007-07-26 3:31 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
Hi,
On Wed, 25 Jul 2007, Junio C Hamano wrote:
> From: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
> Subject: [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar()
> Date: Wed, 25 Jul 2007 12:49:53 -0400
> Message-Id: <11853821962210-git-send-email-bradford.carl.smith@gmail.com>
>
> Changed git_commit_set_multivar() to use the routines provided by
> lockfile.c to reduce code duplication and ensure consistent behavior.
>
> Signed-off-by: "Bradford C. Smith" <bradford.carl.smith@gmail.com>
>
> Dscho, I think this is worth doing regardless of that "symlinked
> config" issue. I haven't followed the code closely enough,
> though.
>
> What do you think?
I think that I will review it tomorrow; this darned work-tree stuff took
way longer than expected.
Ciao,
Dscho
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-26 18:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-25 23:39 [Bradford C. Smith] [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Junio C Hamano
2007-07-26 3:31 ` Johannes Schindelin
[not found] ` <f158199e0707261040u70ee31d3le2eaf21ab1302909@mail.gmail.com>
2007-07-26 18:26 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).